Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method fromCachedConfig should only load config #35

Open
sandrokeil opened this issue Nov 19, 2021 · 0 comments
Open

Method fromCachedConfig should only load config #35

sandrokeil opened this issue Nov 19, 2021 · 0 comments

Comments

@sandrokeil
Copy link
Contributor

The method fromCachedConfig should be split up. It should only load the config and after that, the initialize() method should be called like for the normal initialization. For instance if the $eventQueue parameter is an instance which relies on event engine itself it can only be created via proxy manager.

    public static function fromCachedConfig(
        array $config,
        Schema $schema,
        Flavour $flavour,
        EventStore $eventStore,
        LogEngine $logEngine,
        ContainerInterface $container,
        DocumentStore $documentStore = null,
        MessageProducer $eventQueue = null
    ): self {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant