Change downloading attachments encoding to urlencode (#1251335)

eventum · Nov 18, 2013 · c2ff4eb · c2ff4eb
1 parent b905202
commit c2ff4eb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/docs/ChangeLog b/docs/ChangeLog
@@ -18,6 +18,7 @@ Eventum Issue Tracking System
 - fix bug for adding time entries is broken at the end of month Edit (#1186330)
 - Add Back-Off functionallity (Petter Sandholdt) (GH#4)
 - Redirect to issues listing when signing in (Elan Ruusamäe)
+- Change downloading attachments encoding to urlencode (Elan Ruusamäe) (#1251335)
 
 2012-07-09, Version 2.3.3 RC3
 - Fixed bug #1021258 where users password is not hashed when they are initially created (Bryan Alsdorf)

diff --git a/lib/eventum/class.attachment.php b/lib/eventum/class.attachment.php
@@ -79,9 +79,9 @@ function outputDownload(&$data, $filename, $filesize, $mimetype)
             $filename = ev_gettext("Untitled");
         }
         $disposition = self::displayInline($mimetype) ? 'inline' : 'attachment';
-        $filename = Mime_Helper::encodeQuotedPrintable($filename);
+        $filename = rawurlencode($filename);
         header("Content-Type: " . $mimetype);
-        header("Content-Disposition: {$disposition}; filename=\"{$filename}\"");
+        header("Content-Disposition: {$disposition}; filename=\"{$filename}\"; filename*=".APP_CHARSET."''{$filename}");
         header("Content-Length: {$filesize}");
         echo $data;
         exit;