Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM Integration section bugs - it's colored blue (Public) and show/hide gives fatal error #215

Closed
slay123 opened this issue Oct 31, 2016 · 2 comments · Fixed by #216
Closed

SCM Integration section bugs - it's colored blue (Public) and show/hide gives fatal error #215

slay123 opened this issue Oct 31, 2016 · 2 comments · Fixed by #216
Labels
bug
Milestone
3.1.5

Comments

@slay123
Copy link
Contributor

slay123 commented Oct 31, 2016

  1. it is painted blue, as Public section, but de facto is visible only for internal users, see issue Editors cannot see "Attached Files" section and it's also missing Public/Internal switch #214 for screenshot.
  2. clicking show/hide gives JS error

screenshot 2016-10-31 14 38 10
@slay123 slay123 added the bug label Oct 31, 2016
glensc added a commit to glensc/eventum that referenced this issue Oct 31, 2016
@glensc
fix SCM checkins being displayed as "public", fixes eventum#215
e0917cf
@glensc glensc added this to the 3.1.5 milestone Oct 31, 2016
glensc added a commit to glensc/eventum that referenced this issue Oct 31, 2016
@glensc
fix SCM checkins being displayed as "public", fixes eventum#215
8a59da6
@glensc glensc mentioned this issue Oct 31, 2016
Merged
2 tasks
@glensc
Copy link
Member

glensc commented Oct 31, 2016

i'm unable to reproduce the js error. do you get the error with regular user or reporter?

@glensc
Copy link
Member

glensc commented Oct 31, 2016

ah, the js error comes when clicking these:
image
not these:
image

glensc added a commit that referenced this issue Oct 31, 2016
@glensc
Merge pull request #216 from glensc/fix-215
7c5010a 
fix SCM checkins being displayed as "public", fixes #215
balsdorf pushed a commit to mariadb-corporation/eventum that referenced this issue Dec 14, 2016
@glensc
fix SCM checkins being displayed as "public", fixes eventum#215
32b47f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
3.1.5
Development

Successfully merging a pull request may close this issue.

fix SCM checkins being displayed as "public", fixes #215 glensc/eventum
2 participants
@glensc @slay123