Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From field is garbled if senders name contains unicode #225

Closed
balsdorf opened this issue Dec 9, 2016 · 2 comments
Closed

From field is garbled if senders name contains unicode #225

balsdorf opened this issue Dec 9, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@balsdorf
Copy link
Contributor

balsdorf commented Dec 9, 2016

When sending an email from the web interface, if the senders name contains unicode and "Add Unknown Recipients to Issue Notification List" is not checked the from field will contain the Quoted-printable version of the name, such as =?UTF-8?Q?Admi=C3=B1_User?= issue-60@example.com

image

This is caused by a line of code that is only executed when "Add Unknown" is not checked:

$from = Notification::getFixedFromHeader($issue_id, $from, 'issue');

@balsdorf balsdorf self-assigned this Dec 9, 2016
@balsdorf balsdorf added this to the 3.1.7 milestone Dec 9, 2016
@glensc
Copy link
Member

glensc commented Dec 10, 2016

never refer to source line using branch name, use git tag or git commit instead. problem is that the line numbers get out of place over time.

@balsdorf
Copy link
Contributor Author

Thanks! I had remembered you said something about this before but I couldn't remember what exactly. I've updated this issue

@glensc glensc closed this as completed in dfc15f0 Dec 13, 2016
glensc added a commit that referenced this issue Dec 13, 2016
Don't QP encode sender when storing in the DB. Fixes #225
balsdorf pushed a commit to mariadb-corporation/eventum that referenced this issue Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants