Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Inactive DN" parameter optional as the Help page says #1208

Merged
merged 2 commits into from Sep 23, 2021

Conversation

vladsf
Copy link
Contributor

@vladsf vladsf commented Sep 23, 2021

Make "Inactive DN" parameter optional as the Help page says.

Eventum hides "Customize LDAP Config" page if the parameter is not set. bin/console.php eventum:ldap:sync fails as well.

@glensc glensc added this to the 3.10.7 milestone Sep 23, 2021
@glensc
Copy link
Member

glensc commented Sep 23, 2021

@vladsf please add changelog entry

@vladsf vladsf merged commit 4efb6d2 into eventum:master Sep 23, 2021
@glensc
Copy link
Member

glensc commented Sep 24, 2021

Hah, I didn't realize @vladsf you have enough mana to merge :D

@vladsf vladsf deleted the fixldapopts branch September 24, 2021 09:59
@vladsf
Copy link
Contributor Author

vladsf commented Sep 24, 2021

So it the mana was not added by mistake. OK! :D

@glensc
Copy link
Member

glensc commented Sep 24, 2021

I guess it was added years ago, and I already forgot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants