Fix invalid input for advanced search sort_by #1255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1252:
The fix didn't account for custom fields and resulted sql error in case of invalid input, which resulted a 500 page.
The new fix, field is validated against the list from the adv_search template only when not using custom fields:
eventum/templates/adv_search.tpl.html
Lines 155 to 162 in 81fbd07
Also, the
$sort_by
is now escaped withquoteIdentifier
(method for columns) ratherescape
(method for values)