Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock jquery-ui to 1.12.x #1256

Merged
merged 1 commit into from Nov 9, 2021
Merged

Lock jquery-ui to 1.12.x #1256

merged 1 commit into from Nov 9, 2021

Conversation

glensc
Copy link
Member

@glensc glensc commented Nov 9, 2021

Revert "Bump jquery-ui from 1.12.1 to 1.13.0 (#1240)"

It's not compatible, for example view issue page has such errors on console:

jquery-ui.js?id=44a2af31b10434ff00c4:3226 Uncaught TypeError: $.uniqueSort is not a function
    at processClassString (jquery-ui.js?id=44a2af31b10434ff00c4:3226)
    at $.<computed>.<computed>._classes (jquery-ui.js?id=44a2af31b10434ff00c4:3239)
    at $.<computed>.<computed>._toggleClass (jquery-ui.js?id=44a2af31b10434ff00c4:3276)
    at $.<computed>.<computed>._addClass (jquery-ui.js?id=44a2af31b10434ff00c4:3264)
    at $.<computed>.<computed>._create (jquery-ui.js?id=44a2af31b10434ff00c4:15110)
    at $.<computed>.<computed>._create (jquery-ui.js?id=44a2af31b10434ff00c4:2834)
    at $.<computed>.<computed>._createWidget (jquery-ui.js?id=44a2af31b10434ff00c4:3032)
    at new $.<computed>.<computed> (jquery-ui.js?id=44a2af31b10434ff00c4:2789)
    at HTMLDivElement.<anonymous> (jquery-ui.js?id=44a2af31b10434ff00c4:2972)
    at Function.each (components.js?id=81f149179a79cc2f11e5:648)
    at jQuery.fn.init.each (components.js?id=81f149179a79cc2f11e5:270)
    at jQuery.fn.init.$.fn.<computed> [as progressbar] (jquery-ui.js?id=44a2af31b10434ff00c4:2964)
    at HTMLDivElement.<anonymous> (app.js?id=d0fd6bc6e7450e4c773c:26517)
    at Function.each (components.js?id=81f149179a79cc2f11e5:648)
    at jQuery.fn.init.each (components.js?id=81f149179a79cc2f11e5:270)
    at HTMLDocument.<anonymous> (app.js?id=d0fd6bc6e7450e4c773c:26515)
    at fire (components.js?id=81f149179a79cc2f11e5:1037)
    at Object.fireWith [as resolveWith] (components.js?id=81f149179a79cc2f11e5:1148)
    at Function.ready (components.js?id=81f149179a79cc2f11e5:433)
    at HTMLDocument.completed (components.js?id=81f149179a79cc2f11e5:103)

So such update should be postponed to future version.

Revert "Bump jquery-ui from 1.12.1 to 1.13.0 (eventum#1240)"

This reverts commit d8fc66a.

Revert "Cleanup jquery-ui jquery 1.7 support file from jquery-ui.js bundle"

This reverts commit a28739f.
@glensc glensc added this to the 3.10.8 milestone Nov 9, 2021
@glensc glensc self-assigned this Nov 9, 2021
@glensc
Copy link
Member Author

glensc commented Nov 9, 2021

Seems the method requires jquery 1.12:

@glensc
Copy link
Member Author

glensc commented Nov 9, 2021

Seems the issue here is that the compat file has been renamed:

so, plan is to revert for 3.10.x versions to keep it stable, and not getting any more surprises, and do the upgrade in future eventum versions.

@glensc glensc merged commit be9baf1 into eventum:master Nov 9, 2021
@glensc glensc deleted the jquery-ui-1.12.1 branch November 9, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant