Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert manage pages to Controller logic #128

Merged
merged 48 commits into from
Jan 18, 2016
Merged

Conversation

glensc
Copy link
Member

@glensc glensc commented Jan 15, 2016

Continuing #108, #117, #120 for manage/* pages

in the process, problems came up:

  • email_alias.php delete action only handles last action delete status, fixed in 0f22d98
  • some pages lacked role check, using manager now
    • check_email_settings.php
    • reminder_review.php
  • some pages had wrong level since 09e31e2 (v3.0.4), fixed in 60866f8
    • custom_fields.php
    • customize_listing.php
    • email_accounts.php
    • general.php
    • issue_auto_creation.php
    • ldap.php
    • monitor.php
    • scm.php
  • groups.php had unused $show_customer
  • monitor.php radio boxes were broken (fixed in 7ddf30e)
  • products.php had unused $user_options
  • reminders.php html seems broken
  • users.php some dead code?
  • reminder_review.php uses bogus get_emails.tpl.html template, dropped (33693ea)

progress report:

  • account_managers.php
  • anonymous.php
  • categories.php
  • check_email_settings.php
  • column_display.php
  • customer_notes.php
  • custom_fields.php
  • customize_listing.php
  • email_accounts.php
  • email_alias.php
  • email_responses.php
  • faq.php
  • field_display.php
  • general.php
  • groups.php
  • index.php
  • issue_auto_creation.php
  • ldap.php
  • link_filters.php
  • monitor.php
  • news.php
  • partners.php
  • phone_categories.php
  • priorities.php
  • private_key.php
  • products.php
  • projects.php
  • releases.php
  • reminder_actions.php
  • reminder_conditions.php
  • reminder_review.php
  • reminders.php
  • resolution.php
  • round_robin.php
  • scm.php
  • severities.php
  • statuses.php
  • time_tracking.php
  • users.php

@glensc glensc added this to the 3.0.8 milestone Jan 15, 2016
@glensc glensc self-assigned this Jan 15, 2016
@glensc
Copy link
Member Author

glensc commented Jan 16, 2016

@balsdorf ready for merge!

balsdorf pushed a commit that referenced this pull request Jan 18, 2016
Convert manage pages to Controller logic
@balsdorf balsdorf merged commit fc6e3f5 into master Jan 18, 2016
@glensc glensc deleted the manage-controllers branch January 18, 2016 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants