Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow change project #223

Merged
merged 5 commits into from
Dec 9, 2016
Merged

Workflow change project #223

merged 5 commits into from
Dec 9, 2016

Conversation

balsdorf
Copy link
Contributor

@balsdorf balsdorf commented Nov 30, 2016

This can be used to map values for fields between projects or do other custom changes.

@glensc
Copy link
Member

glensc commented Dec 6, 2016

Should this be called on the workflow of the old project or the new project?

if you're not sure how, you could add two methods:

  • movedFromProject
  • movedToProject

so you can choose which one to implement.

@balsdorf
Copy link
Contributor Author

balsdorf commented Dec 7, 2016

Good idea. I've done that now. I'll do a bit more testing before merge.

Since ChangeLog is conflicting now, should I rebase once everything is good to go?

@glensc
Copy link
Member

glensc commented Dec 8, 2016

i'm planning to make release shortly, so it will conflict even more. and this PR should be merged after the release, to give it more testing ground.

so yes, rebase after release made (and fix @since tags)

* @since 3.1.6
* @return null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't return anything. remove this line

* @param $issue_id
* @param $old_prj_id
* @since 3.1.6
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as minimum, should fill param types

@glensc
Copy link
Member

glensc commented Dec 8, 2016

relased, you may rebase now

@balsdorf
Copy link
Contributor Author

balsdorf commented Dec 9, 2016

Well I royally made a mess with git but I think I managed to fix it all.

@glensc
Copy link
Member

glensc commented Dec 9, 2016

you can see the Commits tab (https://github.com/eventum/eventum/pull/223/commits) what are the actual commits associated, looks good right now.

@balsdorf balsdorf merged commit ff35cec into master Dec 9, 2016
@balsdorf balsdorf deleted the workflow_change_project branch December 9, 2016 18:57
@glensc glensc removed the in progress label Dec 9, 2016
@glensc glensc added this to the 3.1.7 milestone Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants