Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate escapeInteger and escapeString in favor of using placeholders #26

Merged
merged 52 commits into from Feb 2, 2015
Merged

deprecate escapeInteger and escapeString in favor of using placeholders #26

merged 52 commits into from Feb 2, 2015

Conversation

glensc
Copy link
Member

@glensc glensc commented Dec 13, 2014

deprecate escapeInteger and escapeString in favor of using placeholders

overview by classes:

  • product.php 1
  • reminder_condition.php 1
  • resolution.php 1
  • authorized_replier.php 2
  • category.php 2
  • crm.php 2
  • display_column.php 2
  • history.php 2
  • impact_analysis.php 2
  • news.php 2
  • priority.php 2
  • release.php 2
  • reminder.php 2
  • round_robin.php 2
  • scm.php 2
  • severity.php 2
  • email_response.php 3
  • filter.php 3
  • link_filter.php 3
  • phone_support.php 3
  • email_account.php 4
  • faq.php 4
  • reminder_action.php 5
  • time_tracking.php 7
  • group.php 8
  • status.php 8
  • draft.php 10
  • mail_queue.php 11
  • project.php 11
  • attachment.php 15
  • note.php 15
  • user.php 15
  • report.php 23
  • support.php 23
  • notification.php 26
  • custom_field.php 30
  • search.php 38
  • issue.php 103

above list built with:

grep -rcE 'Misc::escape(Integer|String)' lib/eventum/class.*.php|grep -v :0|cut -d/ -f3|sed -e 's/class.//'| tr : ' '|sort +1 -n | sed -e 's/^/- [ ] /'

@glensc
db: add helper to build sql queries with variable length parameters
021d583
@glensc
db: add test for that helper
70b57fd
@glensc
db: attachment: fix code not to use escapeInteger
74a817a
@glensc
misc: mark escapeInteger and escapeString deprecated
99093bc
@glensc
db: add helper to build list of placeholders
b730732
@glensc
db: product: fix code not to use escapeInteger
d8c946a
@glensc
db: reminder_condition: fix code not to use escapeInteger
5dd700e
@glensc
db: resolution: fix code not to use escapeInteger
ba689f0
@glensc
db: authorized_replier: fix code not to use deprecated escapeInteger
8259493
@glensc
db: group: fix code not to use deprecated escapeInteger
f6c4d54
@glensc
db: status: fix code not to use deprecated escapeInteger
4680261
@glensc
status: fix missing params
8d631f5
@glensc
db: category: fix code not to use deprecated escapeInteger
6957f5d
@glensc
db: crm: fix code not to use deprecated escapeInteger
8fc1a4d
@glensc
db: email_account: fix code not to use deprecated escapeInteger
3cb1b13
@glensc
db: email_response: not to use deprecated escapeInteger
cb3ce03
@glensc
db: custom_field: not to use deprecated escapeInteger
107df20
@glensc
db: custom_field: replace some instances of escapeInteger
e16107e 
this class is a mess
@glensc
db: display_column: not to use deprecated escapeInteger
571856b
@glensc
db: draft: not to use deprecated escapeInteger
db173ec
@glensc
db: faq: not to use deprecated escapeInteger/escapeString
0fe7a9f
@glensc
db: add orderBy validator
a2754ae
@glensc
db: history: not to use deprecated escapeInteger/escapeString
2e4ee79
@glensc
db: time_tracking: not to use deprecated escapeInteger/escapeString
d1776a0
@glensc
db: project: not to use deprecated escapeInteger/escapeString
5f1141b
@glensc
fix bad getAssoc usage (second param is force_array)
079beb3
@glensc
group DbTest tests by method names
5c1b302
@glensc
db: add fetchAssoc for simplified interface to getAssoc
1cbaadd
@glensc
replace deprecated getAssoc with fetchAssoc
5d1c40d 
getAssoc interface is confusing, not useful, and therefore deprecated
@glensc
db: impact_analysis: not to use deprecated escapeInteger/escapeString
948fe08
@glensc
db: link_filter: not to use deprecated escapeInteger/escapeString
6008972
@glensc
db: news: not to use deprecated escapeInteger/escapeString
eb73f97
@glensc
db: priority: not to use deprecated escapeInteger/escapeString
e6515ed
@glensc
db: scm: not to use deprecated escapeInteger/escapeString
8c0c39b
@glensc
db: round_robin: not to use deprecated escapeInteger/escapeString
af1bc79
@glensc
db: release: not to use deprecated escapeInteger/escapeString
ff44bdf
@glensc
db: phone_support: not to use deprecated escapeInteger/escapeString
34101af
@glensc
db: reminder: not to use deprecated escapeInteger/escapeString
78789d3
@glensc
db: reminder_action: not to use deprecated escapeInteger/escapeString
8b61513
@glensc
db: severity: not to use deprecated escapeInteger/escapeString
6596f06
@glensc
db: mail_queue: not to use deprecated escapeInteger/escapeString (par…
c38d72e 
…tial)
@glensc
db: user: use buildSet to update user params
0d9ca11
@glensc
db: user: not to use deprecated escapeInteger/escapeString
ab10d07
@glensc
db: note: not to use deprecated escapeInteger/escapeString
2054e5c
@glensc
db: note::insert use BuildSet instead of unreadable gibberish.
38514b6
@glensc
skip DbMaxAllowedPacketTest on travis
e3949f0
@glensc
db: not to use deprecated escapeInteger/escapeString
d128d37
@glensc
db: note: not to use deprecated escapeInteger/escapeString
c357ddc
@glensc
db: mail_queue::add: not to use deprecated escapeInteger/escapeString
e1ab3c3
@glensc
db: notification: not to use deprecated escapeInteger/escapeString
b088128
@glensc
db: notification: not to use deprecated escapeInteger/escapeString
6e1b671
@glensc
db: notification: not to use deprecated escapeInteger/escapeString
7724d37
@glensc glensc merged commit 7724d37 into eventum:master Feb 2, 2015
glensc added a commit that referenced this pull request Feb 2, 2015
@glensc
Merge branch 'db-placeholders'. #26
4c939cc
@glensc
Copy link
Member Author

glensc commented Feb 2, 2015

more left to do after 4c939cc merge:

  • filter.php 2
  • support.php 22
  • report.php 23
  • custom_field.php 25
  • search.php 38
  • issue.php 99

@glensc glensc modified the milestone: 3.0.0 Feb 10, 2015
glensc added a commit that referenced this pull request Feb 17, 2015
@glensc
Merge branch 'db-placeholders'. #26
46b2608 
updated custom_field, support classes.
@glensc
Copy link
Member Author

glensc commented Feb 17, 2015

  • custom_field.php 2
  • filter.php 2
  • support.php 2
  • report.php 23
  • search.php 38
  • issue.php 99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@glensc