add $min_role to base controller #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glensc
force-pushed
the
controller-min-role
branch
from
6cfe32d
to
03b23ef
Compare
see error_message.tpl
show use different base template and omit back link
moved from managecontroller this is because partners.php is not under manage, but also requires min role check
blah, previous code was:
if (Auth::getCurrentRole() <= User::ROLE_USER) {
return false;
}
meaning min_role >= developer is allowed to access
glensc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
originally tried to add
$is_popuptoPartnersController, but the property is used only inManagecontrollers. which just implement simple min_role check.this PR adds
min_roleproperty to controllers, so they can just define property and avoid duplicate code actually checking it.