Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpl: do not use core.current_url #265

Merged
merged 6 commits into from
Jun 12, 2017
Merged

tpl: do not use core.current_url #265

merged 6 commits into from
Jun 12, 2017

Conversation

glensc
Copy link
Member

@glensc glensc commented May 14, 2017

it breaks configurations that are behind proxy
or rewrite rules are being applied

for example i route based on ab cookie value users to "production" instance or "dev" instance using the same urls.

and pages that use current_url get exposed to the "real" url behind the scenes.

rest of the templates use rel_url or base_url, so to cleanup current_url is good for consistency as well.

the same applies for $_SERVER['PHP_SELF']

  • {$core.current_url}
  • $_SERVER['PHP_SELF']

it breaks configurations that are behind proxy
or rewrite rules are being applied
@glensc glensc changed the title WIP: tpl: do not use core.current_url tpl: do not use core.current_url Jun 12, 2017
@glensc glensc merged commit 6ecbe06 into master Jun 12, 2017
@glensc glensc deleted the tpl.current_url branch June 12, 2017 16:54
@glensc glensc added this to the 3.2.2 milestone Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant