Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Status Change Date" field to issue. #277

Merged
merged 4 commits into from
Aug 7, 2017
Merged

Conversation

balsdorf
Copy link
Contributor

I've added a new field to the issue to track when the status was last changed and I've added it to the list issues page as well.

This name conflicts with some old, confusing functionality here (linked from the admin as "Customize Issue Listing Screen") which allows you to choose your own date field to display based on what the status is. I can see some value in this functionality, but I don't use it and am not sure if anyone else does either.

I would like to either rename it to "Status Action Date" (or something better, I'm open to suggestions) or remove the functionality.

Thoughts?

@glensc
Copy link
Member

glensc commented Jul 12, 2017

new field seems ok, not breaking anything. column "Status Change Date" is perfect name IMHO.

as for current functionality you mean "Last Action Date"?

@glensc glensc added this to the 3.2.2 milestone Jul 12, 2017
@balsdorf
Copy link
Contributor Author

Not "Last Action Date",that field is fine. The old field I want to rename / delete is called "Status Change Date" (which is why I titled the new column "Last Status Change Date" until we . See here and here

@slay123
Copy link
Contributor

slay123 commented Jul 20, 2017

Hello. I couldn't see that feature in our system. So perhaps we don't even use it?

What must definitely stay is "Submitted date", "Last updated date" and our custom field "Deadline" (which is actually rarely used). These are date selector fields that we use.

@balsdorf
Copy link
Contributor Author

balsdorf commented Aug 1, 2017

@slay123 Those fields will stay for sure. Like I said, I don't think anyone really uses the old column, but in case they do I'm happy to rename the old field to "Status Action Date"

@glensc
Copy link
Member

glensc commented Aug 1, 2017

@balsdorf as @slay123 concern is preserved, do whatever you please with the old field :) it's hard to give opinion on something that i've never seen :)

if you're unsure, rename it something indicating it will be removed soon, like "Status Action Date [deprecated]" and see if someone complains.

@balsdorf balsdorf changed the title WIP: Add "Status Change Date" field to issue. Add "Status Change Date" field to issue. Aug 3, 2017
@balsdorf
Copy link
Contributor Author

balsdorf commented Aug 3, 2017

Alright I've renamed that old field, a lot more places to change once I decided to be thorough :)

Let me know if you see any problems

Bryan Alsdorf and others added 2 commits August 3, 2017 10:46
phinx doesn't support php namespaces yet for migration classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants