Add experimental markdown rendering #291
Conversation
glensc
force-pushed
the
experiment/markdown
branch
from
1f18db1
to
c66c84d
Compare
glensc
force-pushed
the
experiment/markdown
branch
2 times, most recently
from
61e4539
to
eb64a1a
Compare
glensc
force-pushed
the
experiment/markdown
branch
from
36f1460
to
dc972f8
Compare
|
Works great for me. Only issue is that clicking the 'fixed width' link messes up the display. This can be easily fixed by replacing the description with |
|
can you propose patch? |
|
Maybe like this: inguin/eventum@24f6510 |
|
checked in as dc972f8...4ddf69f |
The 'fixed width' mode for the issue description conflicts with markdown formatting. Render two description nodes, one with variable width and formatting, one with fixed width and no formatting. The 'fixed width' link toggles display between the two.
glensc
force-pushed
the
experiment/markdown
branch
from
4ddf69f
to
f64c20c
Compare
glensc
force-pushed
the
experiment/markdown
branch
from
f64c20c
to
48edb51
Compare
not sure why, that was there for iss_description since initial commit f51c769
extensible and faster (uses tokenizing instead of regexps)
this way existing messages will be rendered almost okay.
used by Custom_Field::formatValue
breaks custom field formatting it broke issue display too, but wasn't important there earlier
this one is called from EmailHelper formatter
The 'fixed width' mode for the issue description conflicts with markdown formatting. Render two description nodes, one with variable width and formatting, one with fixed width and no formatting. The 'fixed width' link toggles display between the two.
glensc
force-pushed
the
experiment/markdown
branch
from
59a4f5c
to
8837f45
Compare
glensc
changed the title
|
looks like the links formatting got broken (none rendered as html links) with markdown disabled mode. this needs to be fixed. cc @balsdorf |
|
It's one solution, but not exactly what I was hoping for. I was hoping for the ability to copy directly from a web page, or just take a screen shot and paste in the image from the buffer etc. This is something that can be done with WSYWIGs sometimes. Even if we could just upload the image, and then have an insert image icon so that we can have a quick way to format images properties (height, width, src= etc.) In the meantime however, your solution will work for images, just a bit more clunky for the non technical users. Thanks for your update! :-) |
|
markdown should support html to some extent, but i haven't tested this. |
|
With turning on Markdown, and then installing CKEditor on any textarea I wanted, it works amazingly well now. With CKEditor with image upload support, I can copy and paste from the buffer, and can also drag and drop files etc. This would be a cool feature to add out of the box :-) .. thanks for your help! This can be closed now! It was not working with just markdown enabled by itself. |
|
so, submit your changes as pull request! |
this works surprisingly well. currently enabled in issue description area.
to test this (besides getting code from this branch and updating composer):
define in
config/setup.phpUPDATE: the option can now be changed from general settings and user preferences.