Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mail-download: fix user_id fetch using email header #336

Merged
merged 9 commits into from Jan 8, 2018
Merged

mail-download: fix user_id fetch using email header #336

merged 9 commits into from Jan 8, 2018

Conversation

glensc
Copy link
Member

@glensc glensc commented Dec 31, 2017 •
edited

functional changes:

  • 8e774d2 - User::getUserIDByEmail takes plain email only as input, not formatted email header
  • 4407ba4 - reuse sender_usr_id
  • 1c78188 - authorized_replier: manualInsert should convert mail header to email first

@balsdorf could you check if the second commit 4407ba4 is safe to do

@glensc
User::getUserIDByEmail takes plain email only as input, not formatted…
8e774d2 
… email header

  [Eventum\Db\DatabaseException (HY000)]
  SQLSTATE[HY000]: General error: 1267 Illegal mix of collations (latin1_swed
  ish_ci,IMPLICIT) and (utf8_general_ci,COERCIBLE) for operation '='
@glensc
strict compare fixes
41a2746
@glensc
substr "-1" optimization
378ff7b
@glensc
use strpos instead
b4ff8b7
@glensc
use array_key_exists optimization
e84c7e0
@glensc
misc cleanup
f212c81
@glensc
reuse sender_usr_id
4407ba4
@glensc glensc added this to the 3.4.0 milestone Dec 31, 2017
@glensc glensc merged commit 38b0bf2 into eventum:master Jan 8, 2018
@glensc glensc deleted the user-id-fetch branch January 8, 2018 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@glensc