update to defuse/php-encryption 2.1 #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
glensc
force-pushed
the
php-encryption
branch
2 times, most recently
from
a32c13d
to
d3d5b11
Compare
glensc
changed the title
|
the db migration: as there's no way to encrypt using old version, should |
|
Sounds like that is the only option. I'm okay with it. |
|
i think will delay merge of this, there are too many changes in 3.4.0 release. have you yourself switched to code currently in master? i have tried mail sending, and have disabled several times due some issues. #353, #352, #350, #351 all somewhat related, those are solved now. but haven't tested in production download_emails.php part much either. |
|
I have not yet but I will next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php-encryption/2.0.0:
NOTE: as the encrypted results are hex encoded by defuse/php-encryption, instead of base64, the result db columns may need to be increased. 1 byte encryption resulted 170 bytes encrypted result and 255 byte got exploded to 678 bytes.
so therefore not using defuse encoding, but keeping our own base64 implementation