Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add maxwidth to issue description, so it will be scrollbar, when too … #64

Merged
merged 1 commit into from
Jul 15, 2015

Conversation

slay123
Copy link
Contributor

@slay123 slay123 commented Jul 15, 2015

…many chars on same line without whitespace
before:
screenshot 2015-07-15 15 48 59

after:
screenshot 2015-07-15 15 49 41

#issue_description {
display: inline-block;
/* 82% from viewport width */
max-width: 82vw;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder what's browser compatibility for this css unit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to:
https://css-tricks.com/viewport-sized-typography/ and
http://caniuse.com/#feat=viewport-units

IE 10+, Firefox 19+, Chrome 34+, Safari 7+, Android 4.4+, iOS 6+ - Supported

For IE should probably add some IE specific CSS hack, something like:
max-width: 995px\9;

Elan Ruusamäe wrote on 15.07.2015 16:59:

In htdocs/css/main.css #64 (comment):

@@ -374,6 +374,13 @@ table.grid tr.no_results td {
text-align: center;
font-style: italic;
}
+/* if issue description is too wide */
+#issue_description {

  • display: inline-block;
    +/* 82% from viewport width */
  • max-width: 82vw;

i wonder what's browser compatibility for this css unit?


Reply to this email directly or view it on GitHub
https://github.com/eventum/eventum/pull/64/files#r34680474.

@glensc glensc added this to the 3.0.2 milestone Jul 15, 2015
glensc added a commit that referenced this pull request Jul 15, 2015
add maxwidth to issue description, so it will be scrollbar, when too …
@glensc glensc merged commit bb1da7e into eventum:master Jul 15, 2015
@slay123 slay123 deleted the fix_wide_description branch October 30, 2015 10:30
glensc added a commit to glensc/eventum that referenced this pull request May 2, 2019
glensc added a commit to glensc/eventum that referenced this pull request May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants