use zf2 config for setup config #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
besides dual usage (via object and array), the Setup::save takes only keys you want to modify, no need for Setup::load and if you modify the retrieved setup, the in-memory version is modified too. using zf2 lts version (2.4)
$reload option is gone, as any modification made to returned object is present in further setup.load calls
that method does not modify actual config!
used to do db part too, but realized that then upgrade tool will fail..
balsdorf
pushed a commit
that referenced
this pull request
Oct 21, 2015
use zf2 config for setup config
|
Looks good! |
glensc
added a commit
that referenced
this pull request
Oct 21, 2015
it's more logical the way it behaves now
|
damn, you were quick to merge this time! i planned to note when PR is ready for merge adding @balsdorf note. i forgot to check version compatibility of this. |
|
looks like composer.json specifies 5.3, but not all files pass syntax lint used in release process: |
|
Sorry about that, last PR's I took too long on so I tried to go through |
|
i will just remove the conflicting files, we don't use them anyway |
glensc
added a commit
that referenced
this pull request
Oct 22, 2015
custom workflow or custom fields may use Setup::load methods
|
also Workflow config access part is not tested. |
glensc
added a commit
to glensc/eventum
that referenced
this pull request
Oct 22, 2015
* remotes/upstream/master: (258 commits) add getProjectId method add getFrom, add test to get header value for from/to/cc add deleteMessage method to ImapMessage class move imap related addons to ImapMessage class move Mail classes to mail subdir add back Setup::load wrapper. eventum#80 strip config/include from composer cleanup zend stuff rm traits which prevent packaging to work fix location of mkdirs changelog update include config subdirs in release package rename Setup::load to Setup::get. eventum#80 forgot important save() method migrate smtp.auth bool setting move various config migrations to single upgrade patch getListing $get_reporters parameter was removed in 05ecdaa rss: use existing method to retrieve tool caption fix weird assign of array setup.load: discard reload option ...
glensc
added a commit
that referenced
this pull request
Oct 24, 2015
glensc
added a commit
that referenced
this pull request
Nov 1, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
besides dual usage (via object and array),
the Setup::save takes only keys you want to modify, no need for Setup::load
and if you modify the retrieved setup, the in-memory version is modified too.
using zf2 lts version (2.4)