Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] 'Daily Plan' | Notifications 'Remaining tasks' UI #2668

Closed
KostyaEver opened this issue Jul 1, 2024 · 7 comments · Fixed by #2740
Closed

[Improvement] 'Daily Plan' | Notifications 'Remaining tasks' UI #2668

KostyaEver opened this issue Jul 1, 2024 · 7 comments · Fixed by #2740
Assignees
Milestone

Comments

@KostyaEver
Copy link

Fix content that is in the Notification

Should be text: Text: 'You have 'X' uncompleted tasks, please check in 'Outstanding'

on the right part two buttons

  • 'View' (open tab 'Daily Plan' tab 'Outstanding'
  • 'X' (close notification
Screenshot at Jul 01 16-35-53
@GloireMutaliko21
Copy link
Member

Sir @evereq / @KostyaEver I already worked on same issue, exactly same feature and same description.
Please see :

@evereq
Copy link
Member

evereq commented Jul 16, 2024

@KostyaEver can you check if its really same? If so, can we close this ticket??

@KostyaEver
Copy link
Author

Could you see the difference? @GloireMutaliko21
this
#2619
and 2668

They are different because 'Feature' was in general implemented correctly with few mistakes and this task is aimed at fixing these mistakes [Improvement'

PS: not sure why but in most cases small details are missed always and I need to create similar tasks to fix them

CC @evereq

@evereq
Copy link
Member

evereq commented Jul 16, 2024

@KostyaEver can you write here what are diff exactly? Just a hint for devs, thanks! :)

@evereq evereq assigned GloireMutaliko21 and unassigned Anishali2 Jul 16, 2024
@evereq
Copy link
Member

evereq commented Jul 16, 2024

And @GloireMutaliko21 after @KostyaEver explain, please work on this task to finalize this

@GloireMutaliko21
Copy link
Member

@KostyaEver if it's about that short form difference, "You've" instead of "You have", Let's please close this ticket as I can fix it (less than 30 seconds) in the PR I'm working on now ...
CC: @evereq

@KostyaEver
Copy link
Author

In the description all as it should be @GloireMutaliko21

the main problem was that currently text ends on 'Outstanding View' + button 'View' which looks really strange and not sure why it was added.
Also if I am not mistaken when the user clicks the button 'View' it redirects to the wrong page, which should be logical to 'Outstanding'

@GloireMutaliko21 GloireMutaliko21 linked a pull request Jul 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants