Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParameterSet count too low #72

Closed
TGruett opened this issue Feb 29, 2024 · 1 comment
Closed

ParameterSet count too low #72

TGruett opened this issue Feb 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@TGruett
Copy link

TGruett commented Feb 29, 2024 •
edited
Loading

Describe the bug

Hi,

In PR 32, the limit for ParameterSets was set to 5. As has been shown, this limit is somewhat too low in practice. As long as the loop implementation for large arrays is missing, i recommend to increase this value.

To Reproduce

Encode/Decode ServiceDetailRes with 6 or more ParameterSets

Anything else?

Why is there even this limit for more than 25 occurs? Everything seems to work for me if i remove that limit
@TGruett TGruett added the bug Something isn't working label Feb 29, 2024
@TGruett TGruett changed the title ParameterSet count ParameterSet count too low Feb 29, 2024
@barsnick
Copy link
Contributor

We also noticed the same issue recently. By chance, our own products use a higher limit.

I agree with a size of 8, perhaps 16 is okay as well.

barsnick added a commit that referenced this issue Mar 13, 2024
@barsnick
config: increase size of ParameterType
5cf46de 
A size of five proved impractical for real-world use cases. Increase to eight.

ParameterSet is reduced from five to four.

Fixes #72.

Signed-off-by: Moritz Barsnick <moritz.barsnick@chargebyte.com>
@barsnick barsnick mentioned this issue Mar 13, 2024
Merged
3 tasks
barsnick added a commit that referenced this issue Apr 22, 2024
@barsnick
config: increase size of ParameterType
72e74df 
A size of five proved impractical for real-world use cases. Increase to eight.

ParameterSet is reduced from five to four.

Fixes #72.

Signed-off-by: Moritz Barsnick <moritz.barsnick@chargebyte.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@barsnick @TGruett