Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xliff 1.2 serializer #78

Merged
merged 1 commit into from
Jan 3, 2019
Merged

Xliff 1.2 serializer #78

merged 1 commit into from
Jan 3, 2019

Conversation

dragosv
Copy link
Contributor

@dragosv dragosv commented Jul 10, 2018

Xliff 1.2 Serializer that is meant to be extended using the apply_xslt plugin (#77)

@dragosv dragosv mentioned this pull request Jul 10, 2018
@codecov-io
Copy link

codecov-io commented Jul 10, 2018

Codecov Report

Merging #78 into master will increase coverage by 0.58%.
The diff coverage is 79.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   50.95%   51.54%   +0.58%     
==========================================
  Files          89       90       +1     
  Lines        6727     6841     +114     
  Branches     1696     1718      +22     
==========================================
+ Hits         3428     3526      +98     
- Misses       2646     2655       +9     
- Partials      653      660       +7
Impacted Files Coverage Δ
lib/Serge/Engine/Plugin/serialize_xliff.pm 79.82% <79.82%> (ø)
lib/Serge/DB.pm 65.7% <0%> (+0.52%) ⬆️
lib/Serge/DB/Cached.pm 62.92% <0%> (+1.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63ca08b...2eb89da. Read the comment docs.

@dragosv
Copy link
Contributor Author

dragosv commented Jul 13, 2018

In order to understand the way the xliff serializer is intended to be used (apply_xslt on before_deserialize_ts_file and after_serialize_ts_file) take a look at https://github.com/dragosv/serge/tree/xliff_full (tests on apply_xslt). Will pull request this branch as well, once both dependent pull request are merged.

@dragosv
Copy link
Contributor Author

dragosv commented Jul 13, 2018

To be more explicit, xliff support differs between translation providers, requiring all kinds of changes. The two big variations are either needing resname on the trans-unit element or only supporting the id attribute and just the very basic xliff implementation (just source, target and note elements).

@dragosv dragosv force-pushed the xliff branch 5 times, most recently from 3187e6b to e22f1d4 Compare July 17, 2018 17:45
Build.PL Outdated Show resolved Hide resolved
Build.PL Outdated
@@ -1,80 +1,81 @@
use 5.010_001;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you changed the entire file from CRLF to LF. While this might be a welcome change by itself, it's not a part of the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

This commit adds the serialize_xliff plugin needed for serge-community#101
@iafan iafan merged commit 7a00a93 into serge-community:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants