-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xliff 1.2 serializer #78
Conversation
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 50.95% 51.54% +0.58%
==========================================
Files 89 90 +1
Lines 6727 6841 +114
Branches 1696 1718 +22
==========================================
+ Hits 3428 3526 +98
- Misses 2646 2655 +9
- Partials 653 660 +7
Continue to review full report at Codecov.
|
d02caad
to
dd4a78b
Compare
In order to understand the way the xliff serializer is intended to be used (apply_xslt on before_deserialize_ts_file and after_serialize_ts_file) take a look at https://github.com/dragosv/serge/tree/xliff_full (tests on apply_xslt). Will pull request this branch as well, once both dependent pull request are merged. |
To be more explicit, xliff support differs between translation providers, requiring all kinds of changes. The two big variations are either needing resname on the trans-unit element or only supporting the id attribute and just the very basic xliff implementation (just source, target and note elements). |
3187e6b
to
e22f1d4
Compare
3df6020
to
6ee2326
Compare
Build.PL
Outdated
@@ -1,80 +1,81 @@ | |||
use 5.010_001; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you changed the entire file from CRLF to LF. While this might be a welcome change by itself, it's not a part of the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
c78daf5
to
2eb89da
Compare
This commit adds the serialize_xliff plugin needed for serge-community#101
Xliff 1.2 Serializer that is meant to be extended using the apply_xslt plugin (#77)