Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Commit

Permalink
Remove change of file mode on files
Browse files Browse the repository at this point in the history
This appears to be here to allow recursive copying in the case of nested
directories.

This causes some issues though:

* It adds exec bits to every file, not just to directories
* A call to mode.to_i.even? that takes into account the entire mode
rather than just the number it is talking about.
    * In the case of an 0700 mode it be bumped up to 0800 and be invalid
  • Loading branch information
Mark Lakewood authored and jeffbyrnes committed Jan 17, 2017
1 parent 5a33bf7 commit ddf5037
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions libraries/s3_dir.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ def self.dir_mode(mode)
mode = mode.to_s(8)
end

(-3..-1).each do |i|
mode[i] = (mode[i].to_i + 1).to_s if !mode[i].to_i.zero? && mode.to_i.even?
end
mode
end

Expand Down

0 comments on commit ddf5037

Please sign in to comment.