You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To make it easier to try Citadel, and ensure that new changes don't prevent the app from working for long, add a CI pipeline using GitHub Actions to build main anytime it's updated, and run any tests.
The build should be a matrix supporting
Ubuntu/Debian builds
macOS
In the future, if there is appeal, we can add Windows builds + non-appimage/.deb builds.
Stretch goal
Add a CI pipeline that, on PR open or updated, runs static checks like linting & formatting checks (ensure code is correctly formatted). I haven't run these in a while, so there are likely to be some errors. The first step is to open a PR that resolves any lint/format issues without adding CI.
I've set up a very rough CI process that builds on pushes to main (and PRs, although uploads should be disabled for those), uploads the artifacts to the Action, and creates a Draft release. I'm open to feedback / changes here, because I don't like it, but something is better than nothing.
Specifically:
is it easy to access artifacts from GH actions?
do we really need a release for every push to main? I think not. A manual "this build is good" process could create that release.
PRs should build the app but not publish the artifacts, esp. not as a new Release.
To make it easier to try Citadel, and ensure that new changes don't prevent the app from working for long, add a CI pipeline using GitHub Actions to build
main
anytime it's updated, and run any tests.The build should be a matrix supporting
In the future, if there is appeal, we can add Windows builds + non-appimage/.deb builds.
Stretch goal
Add a CI pipeline that, on PR open or updated, runs static checks like linting & formatting checks (ensure code is correctly formatted). I haven't run these in a while, so there are likely to be some errors. The first step is to open a PR that resolves any lint/format issues without adding CI.
Further reading
The text was updated successfully, but these errors were encountered: