Merge pull request #2498 from evidence-dev/fix/2496-better-error-mess…

…age-when-running-sources-without-a-sources-directory

Better error message when running sources without a sources directory

.changeset/olive-oranges-learn.md

@@ -0,0 +1,5 @@
+---
+'@evidence-dev/sdk': patch
+---
+
+Dont throw error if sources directory doesn't exist when running sources

packages/lib/sdk/src/plugins/datasources/evalSources.js

@@ -29,14 +29,16 @@ export const evalSources = async (dataPath, metaPath, filters, strict) => {
 	// Setup work
 	const [sourcePlugins, sources] = await Promise.all([
 		loadSourcePlugins(),
-		loadSources(),
+		loadSources(pluginLoader),
 		loadCache(metaPath)
 	]).catch((e) => {
 		pluginLoader.fail();
 		throw e;
 	});
 
-	pluginLoader.succeed();
+	if (sources.length) {
+		pluginLoader.succeed();
+	}
 
 	/** @type {import('./types.js').Manifest} */
 	const outputManifest = { renderedFiles: {}, locatedFiles: {}, locatedSchemas: [] };

packages/lib/sdk/src/plugins/datasources/loadSources.js

@@ -20,12 +20,22 @@ const loadSource = async (sourcePath) => {
 };
 
 /**
+ * @param {import('ora').Ora} [spinner]
  * @returns {Promise<Array<import('./schemas/datasource.schema.js').DatasourceSpecFile & {dir: string}>>}
  */
-export const loadSources = async () => {
-	const sourceDirs = await fs
-		.readdir(sourcesDirectory)
-		.then((dirs) => dirs.map((dir) => path.join(sourcesDirectory, dir)));
+export const loadSources = async (spinner) => {
+	/** @type {string[]} */
+	let sourceDirs = [];
+	try {
+		sourceDirs = await fs
+			.readdir(sourcesDirectory)
+			.then((dirs) => dirs.map((dir) => path.join(sourcesDirectory, dir)));
+	} catch (e) {
+		spinner?.stopAndPersist({
+			symbol: '⚠',
+			text: chalk.yellow('No sources directory found, no sources to run')
+		});
+	}
 
 	return /** @type {Array<import('./schemas/datasource.schema.js').DatasourceSpecFile & {dir: string}>}*/ (
 		await Promise.all(