Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value component error icon #873

Merged
merged 4 commits into from
May 16, 2023

Conversation

nidhi-kala
Copy link
Contributor

@nidhi-kala nidhi-kala commented May 15, 2023

Description

Addressing #788
Value component error icon is white and positioned in the center.

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset

Before:
image

After:
Screenshot 2023-05-14 at 20 59 59

@changeset-bot
Copy link

changeset-bot bot commented May 15, 2023

🦋 Changeset detected

Latest commit: 1ac6087

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@evidence-dev/components Patch
@evidence-dev/evidence Patch
evidence-test-environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evidence-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 2:58pm

@netlify
Copy link

netlify bot commented May 15, 2023

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit 1ac6087
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/64639982374c14000895fad5
😎 Deploy Preview https://deploy-preview-873--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@archiewood
Copy link
Member

This UI test is being flaky but there is nothing this PR touches that could cause our suite to fail

@archiewood archiewood merged commit b768cf9 into evidence-dev:main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants