Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DockerfileTest fails: No PostgreSQL, Node and Yarn sections generated #14

Closed
oliverklee opened this issue Mar 25, 2022 · 1 comment
Closed

DockerfileTest fails: No PostgreSQL, Node and Yarn sections generated #14

oliverklee opened this issue Mar 25, 2022 · 1 comment

Comments

@oliverklee
Copy link
Contributor

https://github.com/evilmartians/ruby-on-whales/runs/5660599326?check_suite_focus=true

According to the test run in https://github.com/evilmartians/ruby-on-whales/runs/5660599326?check_suite_focus=true, the Dockerfile generated in the tests does not have the sections that are within conditions that depend on the variables postgres_version, node_version and yarn_version, causing the test to fail.

I don't know whether the generator is broken or whether the it is the test.
@palkan
Copy link
Member

palkan commented Mar 28, 2022

That's the tests issue.
I haven't figured out how to resolve these random failures (especially on CI), yet 😞

@palkan palkan closed this as completed Mar 28, 2022
@palkan palkan mentioned this issue Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliverklee @palkan