Bug Report: GEM_AMC Address Table Does Not have XInclude Lines

[bdorney]

Right now when updating the address table used on a host machine it does not have the appropriate XInclude lines to catch the OH address table as described:

cms-gem-daq-project/xhal#36

This requires a user to undergo tedious actions, e.g. insert the lines by hand each time, when updating address tables.

Specifically:

Remove the lines:

<node id=top>
...
</node>

Then change the GEM_AMC node declaration too:

<node id='GEM_AMC' xmlns:xi="http://www.w3.org/2001/XInclude">

Finally as shown in the xhal pull request above, just following the line in the OH${OH_IDX} node just before the GEB node add:

<xi:include href="optohybrid_registers.xml"/>

The resulting part of xml should look like this:

     <node id="OH${OH_IDX}"  address="0x0"
            description="Optohybrid ${OH_IDX}"
            generate="true" generate_size="2" generate_address_step="0x00010000" generate_idx_var="OH_IDX">

        <!--Insert here the OH FPGA module -->
        <xi:include href="optohybrid_registers.xml"/>

        <node id="GEB"  address="0x100000"
              description="VFAT3 registers"> 

Could the next release of AMC FW include this update to the address table as was requested in the past?

Issue exists in: GEM_AMC release v3.4.3.

@mexanick @jsturdy @evka85 @andrewpeck

[bdorney]

Issue is no longer present in releases beyond 3.7.X