Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] generate_registers.py generates an invalid uhal address table for the BLASTER RAM #24

Closed
jsturdy opened this issue Nov 16, 2018 · 4 comments

Comments

@jsturdy
Copy link
Contributor

jsturdy commented Nov 16, 2018

The uhal generated address table has a typo:

<node id="GBT" address="0x0" permission="rw" mode="block"size="3312"/>

which should be (space between the " closing the mode and the next key size):

<node id="GBT" address="0x0" permission="rw" mode="block" size="3312"/>
@jsturdy
Copy link
Contributor Author

jsturdy commented Feb 6, 2019

@evka85, as mentioned in person, the problem is here:

if node.permission is not None:
file.write('permission="%s" ' % node.permission)
if node.mask is not None:
file.write('mask="%s"' % hex(node.mask))
if node.mode is not None:
file.write('mode="%s"' % node.mode)
if node.size is not None:
file.write('size="%s"' % node.size)

where there are no leading/trailing spaces for mask/mode/size

@jsturdy
Copy link
Contributor Author

jsturdy commented Jun 5, 2019

@evka85 this needs to be fixed before the next FW release

@evka85
Copy link
Owner

evka85 commented Jun 13, 2019

fixed in v3.8.4

@evka85 evka85 closed this as completed Jun 13, 2019
@jsturdy
Copy link
Contributor Author

jsturdy commented Jun 27, 2019

Not fixed... see cms-gem-daq-project/cmsgemos#292 (or incorrect address tables attached to release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants