Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n2 selects 8 jobs on a 16 core 32 thread system #21

Closed
tru opened this issue Mar 31, 2022 · 4 comments
Closed

n2 selects 8 jobs on a 16 core 32 thread system #21

tru opened this issue Mar 31, 2022 · 4 comments

Comments

@tru
Copy link
Contributor

tru commented Mar 31, 2022

I have a Ryzen 3950x with 16 cores and 32 threads. Just running n2 with no -j arg selected 8 workers. Ninja selects 34 on the same system.

@tru
Copy link
Contributor Author

tru commented Mar 31, 2022

Oh I see it's hardcoded: https://github.com/evmar/n2/blob/main/src/main.rs#L137

@evmar
Copy link
Owner

evmar commented Mar 31, 2022

Coincidentally I just fixed this earlier today, 3559538

Lemme know if it doesn't work for you.

@tru
Copy link
Contributor Author

tru commented Mar 31, 2022

Oh yeah - I had fetched but not rebuilt the latest. It works, but it selects 32 instead of 34 as in ninja. Doubt it matter much - but I thought I'll just raise it anyway.

@evmar
Copy link
Owner

evmar commented Mar 31, 2022

Oh hm, Ninja does a thing where it adds to the processor count, I will think about it, thanks.

@evmar evmar closed this as completed Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants