fix(upgrade): add account number and sequence to migrated IBC escrow accounts #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
GAtom22
requested review from
Vvaradinov,
0a1c,
danburck,
facs95 and
a team
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1252 +/- ##
==========================================
- Coverage 76.33% 76.26% -0.08%
==========================================
Files 149 149
Lines 8283 8291 +8
==========================================
Hits 6323 6323
- Misses 1768 1774 +6
- Partials 192 194 +2
|
ENG-1344 migrated accounts all have account_number 0
@tom I’m reviewing your module account test and wondering why all the module accounts have a |
fedekunze
approved these changes
Jan 18, 2023
|
@GAtom22 can you double-check that we still have 36 addresses and not more? |
Updated, we have 37 ATM |
danburck
approved these changes
Jan 18, 2023
|
@Mergifyio backport release/v11.0.x |
mergify bot
pushed a commit
that referenced
this pull request
Jan 20, 2023
…accounts (#1252) * fix(upgrade): add account number and sequence to migrated escrow accounts * fix(upgrade): small changes * fix(upgrade): fix linting issues * fix(upgrade) add changelog entry * fix(upgrade) apply review comments * fix(upgrade): add note on docs about escrow accounts * fix(upgrade): update open channels to 37 * fix(upgrade): fix md linting issues (cherry picked from commit 1655308)
✅ Backports have been created
|
fedekunze
added a commit
that referenced
this pull request
Jan 20, 2023
…accounts (backport #1252) (#1263) fix(upgrade): add account number and sequence to migrated IBC escrow accounts (#1252) * fix(upgrade): add account number and sequence to migrated escrow accounts * fix(upgrade): small changes * fix(upgrade): fix linting issues * fix(upgrade) add changelog entry * fix(upgrade) apply review comments * fix(upgrade): add note on docs about escrow accounts * fix(upgrade): update open channels to 37 * fix(upgrade): fix md linting issues (cherry picked from commit 1655308) Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
fedekunze
added a commit
that referenced
this pull request
Jan 30, 2023
* chore(upgrade): release v11-rc1 (#1247) * fix(upgrade): add recovery store on store upgrade (backport #1257) (#1261) * fix(upgrade): add recovery store on store upgrade (#1257) * fix(upgrade): add recovery store on store upgrade * fix(upgrade): add changelog entry (cherry picked from commit 2f9b1da) # Conflicts: # CHANGELOG.md * conflict Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * fix(upgrade): add account number and sequence to migrated IBC escrow accounts (backport #1252) (#1263) fix(upgrade): add account number and sequence to migrated IBC escrow accounts (#1252) * fix(upgrade): add account number and sequence to migrated escrow accounts * fix(upgrade): small changes * fix(upgrade): fix linting issues * fix(upgrade) add changelog entry * fix(upgrade) apply review comments * fix(upgrade): add note on docs about escrow accounts * fix(upgrade): update open channels to 37 * fix(upgrade): fix md linting issues (cherry picked from commit 1655308) Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * imp(inflation): remove dup store calls and improve perf (backport #1258) (#1262) * imp(inflation): remove dup store calls and improve perf (#1258) * imp(inflation): remove dup store calls and improve perf * changelog * add logger * tests (cherry picked from commit 76dcaf8) # Conflicts: # CHANGELOG.md # x/inflation/migrations/v3/migrate_test.go * conflict * changelog Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * fix(inflation): re-add missing key to avoid keys shift (backport #1259) (#1260) * fix(inflation): re-add missing key to avoid keys shift (#1259) * fix: added correct int type for periods in store migration * fix: added error checking * fix: removed old param getting * Update x/inflation/migrations/v3/migrate.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * fix: revert removal of missing key * Changelog entry Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 127ac76) # Conflicts: # CHANGELOG.md * conflict Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * chore(upgrade): changelog and const (#1264) * chore (deps): bump Ethermint to v0.21.0-rc2 (backport #1269) (#1270) * chore (deps): bump Ethermint to v0.21.0-rc2 (#1269) * bump Ethermint to v0.21.0-rc2 * update ethermintserver syntax in root.go * lint * update based on review comments Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: tom <tomasguerraalda@hotmail.com> * update changelog entry * update PR number * fix md link Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * chore: v11-rc2 changelog (#1272) * fix(app): store upgrades for rc3 (#1276) * fix(app): store upgrades for rc3 * c++ * fix: test changes deleting module and renaming * fix: recovery added and deleted * fix: rename module * update store loader * fix: finished store_loader * Update app/app.go Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com> * fix: app.go customStoreLoader * fix: execute replaced first * Update app/store_loader.go Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com> * fix: original plan of deleting and readding module * rm loader, update keys * lint * c++ * Apply suggestions from code review Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com> Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com> Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * chore(deps): bump SDK to v0.46.8-ledger (backport #1279) (#1280) * chore(deps): bump SDK to v0.46.8-ledger (#1279) * chore(deps): bump SDK to v0.46.8-ledger * c++ (cherry picked from commit ef71537) # Conflicts: # CHANGELOG.md # go.mod # go.sum * Apply suggestions from code review * conflicts Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * fix(upgrade): remove deletion of recovery module from mainnet upgrade (#1282) * fix: removed deleted recovery module for mainnet * run formatting and linting * upgrade: update olympus-mons distribution (backport #1286) (#1287) upgrade: update olympus-mons distribution (#1286) * fix; updated olympus mons distribution * fix: formatter and linter (cherry picked from commit ca36b98) Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com> * chore (deps): bump ethermint to v0.21.0 (backport #1288) (#1291) * chore (deps): bump ethermint to v0.21.0 (#1288) * bump ethermint to v0.21.0 * add changelog entry (cherry picked from commit efe9cc7) # Conflicts: # CHANGELOG.md * fix merge conflicts in changelog * update release on changelog Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Co-authored-by: MalteHerrmann <malte@evmos.org> * remove rc3 changes * run go mod tidy * remove unnecessary variable declaration for v11 upgrade handler --------- Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com>
fedekunze
added a commit
that referenced
this pull request
Feb 7, 2023
* chore(upgrade): release v11-rc1 (#1247) * fix(upgrade): add recovery store on store upgrade (backport #1257) (#1261) * fix(upgrade): add recovery store on store upgrade (#1257) * fix(upgrade): add recovery store on store upgrade * fix(upgrade): add changelog entry (cherry picked from commit 2f9b1da) # Conflicts: # CHANGELOG.md * conflict Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * fix(upgrade): add account number and sequence to migrated IBC escrow accounts (backport #1252) (#1263) fix(upgrade): add account number and sequence to migrated IBC escrow accounts (#1252) * fix(upgrade): add account number and sequence to migrated escrow accounts * fix(upgrade): small changes * fix(upgrade): fix linting issues * fix(upgrade) add changelog entry * fix(upgrade) apply review comments * fix(upgrade): add note on docs about escrow accounts * fix(upgrade): update open channels to 37 * fix(upgrade): fix md linting issues (cherry picked from commit 1655308) Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * imp(inflation): remove dup store calls and improve perf (backport #1258) (#1262) * imp(inflation): remove dup store calls and improve perf (#1258) * imp(inflation): remove dup store calls and improve perf * changelog * add logger * tests (cherry picked from commit 76dcaf8) # Conflicts: # CHANGELOG.md # x/inflation/migrations/v3/migrate_test.go * conflict * changelog Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * fix(inflation): re-add missing key to avoid keys shift (backport #1259) (#1260) * fix(inflation): re-add missing key to avoid keys shift (#1259) * fix: added correct int type for periods in store migration * fix: added error checking * fix: removed old param getting * Update x/inflation/migrations/v3/migrate.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * fix: revert removal of missing key * Changelog entry Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 127ac76) # Conflicts: # CHANGELOG.md * conflict Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * chore(upgrade): changelog and const (#1264) * chore (deps): bump Ethermint to v0.21.0-rc2 (backport #1269) (#1270) * chore (deps): bump Ethermint to v0.21.0-rc2 (#1269) * bump Ethermint to v0.21.0-rc2 * update ethermintserver syntax in root.go * lint * update based on review comments Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: tom <tomasguerraalda@hotmail.com> * update changelog entry * update PR number * fix md link Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * chore: v11-rc2 changelog (#1272) * fix(app): store upgrades for rc3 (#1276) * fix(app): store upgrades for rc3 * c++ * fix: test changes deleting module and renaming * fix: recovery added and deleted * fix: rename module * update store loader * fix: finished store_loader * Update app/app.go Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com> * fix: app.go customStoreLoader * fix: execute replaced first * Update app/store_loader.go Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com> * fix: original plan of deleting and readding module * rm loader, update keys * lint * c++ * Apply suggestions from code review Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com> Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com> Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * chore(deps): bump SDK to v0.46.8-ledger (backport #1279) (#1280) * chore(deps): bump SDK to v0.46.8-ledger (#1279) * chore(deps): bump SDK to v0.46.8-ledger * c++ (cherry picked from commit ef71537) # Conflicts: # CHANGELOG.md # go.mod # go.sum * Apply suggestions from code review * conflicts Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * fix(upgrade): remove deletion of recovery module from mainnet upgrade (#1282) * fix: removed deleted recovery module for mainnet * run formatting and linting * upgrade: update olympus-mons distribution (backport #1286) (#1287) upgrade: update olympus-mons distribution (#1286) * fix; updated olympus mons distribution * fix: formatter and linter (cherry picked from commit ca36b98) Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com> * chore (deps): bump ethermint to v0.21.0 (backport #1288) (#1291) * chore (deps): bump ethermint to v0.21.0 (#1288) * bump ethermint to v0.21.0 * add changelog entry (cherry picked from commit efe9cc7) # Conflicts: # CHANGELOG.md * fix merge conflicts in changelog * update release on changelog Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Co-authored-by: MalteHerrmann <malte@evmos.org> * imp(deps): use informal tendermint (backport #1248) (#1344) * fix: use informal tendermint (#1248) (cherry picked from commit 4251d93) # Conflicts: # CHANGELOG.md * changelog --------- Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * chore (deps): bump Tendermint to `v0.34.25` (backport #1342) (#1345) * fix(deps): bump Tendermint to `v0.34.25` (#1342) * bump Tendermint to v0.34.25 * update changelog * Apply suggestions from code review * fix --------- Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit e1da176) # Conflicts: # go.mod # go.sum * conflict --------- Co-authored-by: Freddy Caceres <facs95@gmail.com> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * imp (proto): add GH action to push Protobuf files to the Buf Schema Registry (backport #1312) (#1346) imp (proto): add GH action to push Protobuf files to the Buf Schema Registry (#1312) * add GH action to push protos to BSR * push only when release tags are created Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> --------- Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 9cf3d75) Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * fix changelog * fix --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com> Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Co-authored-by: MalteHerrmann <malte@evmos.org> Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com> Co-authored-by: Freddy Caceres <facs95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add account number and sequence to migrated IBC escrow accounts.
During testing the new changes on the last testnet upgrade, it was observed that the migrated accounts had an
account_number == 0This PR includes the changes to fix this by using the
account_numberthat belongs to the existing accountCloses ENG-1344