Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp (proto): add GH action to push Protobuf files to the Buf Schema Registry #1312

Merged
merged 4 commits into from
Feb 1, 2023

Conversation

MalteHerrmann
Copy link
Contributor

Description

We host our Protobuf implementation in the Buf Schema Registry. This PR adds a GitHub action to automatically push changes to the Proto implementation on main to the BSR.


Closes ENG-1449

@linear
Copy link

linear bot commented Feb 1, 2023

ENG-1449 Add GH action to push Protobuf files to BSR

We host our Protobuf implementation in the Buf Schema Registry (https://buf.build/evmos/evmos). Currently, we need to push manually, but there is a Github action available to automatically do this upon changes to the Proto implementation.

That way we always serve the most recent implementation on that resource.

@github-actions github-actions bot added the CI label Feb 1, 2023
@MalteHerrmann
Copy link
Contributor Author

@fedekunze according to the action docs, we'll need to issue a BSR token to grant access to this action and add it to the GH action secrets - haven't done this before (not sure I even have the rights), can you help?

@MalteHerrmann MalteHerrmann marked this pull request as ready for review February 1, 2023 10:53
@MalteHerrmann MalteHerrmann requested a review from a team as a code owner February 1, 2023 10:53
@MalteHerrmann MalteHerrmann requested review from Vvaradinov and GAtom22 and removed request for a team February 1, 2023 10:53
Copy link
Contributor

@GAtom22 GAtom22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @MalteHerrmann !!

MalteHerrmann and others added 2 commits February 1, 2023 12:33
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
@fedekunze fedekunze merged commit 9cf3d75 into main Feb 1, 2023
@fedekunze fedekunze deleted the malte/add-buf-push-action branch February 1, 2023 11:35
@fedekunze
Copy link
Contributor

@Mergifyio backport release/v11.0.x

mergify bot pushed a commit that referenced this pull request Feb 4, 2023
…egistry (#1312)

* add GH action to push protos to BSR

* push only when release tags are created

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

---------

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
(cherry picked from commit 9cf3d75)
@mergify
Copy link
Contributor

mergify bot commented Feb 4, 2023

backport release/v11.0.x

✅ Backports have been created

fedekunze pushed a commit that referenced this pull request Feb 4, 2023
…egistry (backport #1312) (#1346)

imp (proto): add GH action to push Protobuf files to the Buf Schema Registry (#1312)

* add GH action to push protos to BSR

* push only when release tags are created

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

---------

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
(cherry picked from commit 9cf3d75)

Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
fedekunze added a commit that referenced this pull request Feb 7, 2023
* chore(upgrade): release v11-rc1 (#1247)

* fix(upgrade): add recovery store on store upgrade (backport #1257) (#1261)

* fix(upgrade): add recovery store on store upgrade (#1257)

* fix(upgrade): add recovery store on store upgrade

* fix(upgrade): add changelog entry

(cherry picked from commit 2f9b1da)

# Conflicts:
#	CHANGELOG.md

* conflict

Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* fix(upgrade): add account number and sequence to migrated IBC escrow accounts (backport #1252) (#1263)

fix(upgrade): add account number and sequence to migrated IBC escrow accounts (#1252)

* fix(upgrade): add account number and sequence to migrated escrow accounts

* fix(upgrade): small changes

* fix(upgrade): fix linting issues

* fix(upgrade) add changelog entry

* fix(upgrade) apply review comments

* fix(upgrade): add note on docs about escrow accounts

* fix(upgrade): update open channels to 37

* fix(upgrade): fix md linting issues

(cherry picked from commit 1655308)

Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* imp(inflation): remove dup store calls and improve perf (backport #1258) (#1262)

* imp(inflation): remove dup store calls and improve perf (#1258)

* imp(inflation): remove dup store calls and improve perf

* changelog

* add logger

* tests

(cherry picked from commit 76dcaf8)

# Conflicts:
#	CHANGELOG.md
#	x/inflation/migrations/v3/migrate_test.go

* conflict

* changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* fix(inflation): re-add missing key to avoid keys shift (backport #1259) (#1260)

* fix(inflation): re-add missing key to avoid keys shift (#1259)

* fix: added correct int type for periods in store migration

* fix: added error checking

* fix: removed old param getting

* Update x/inflation/migrations/v3/migrate.go

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* fix: revert removal of missing key

* Changelog entry

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
(cherry picked from commit 127ac76)

# Conflicts:
#	CHANGELOG.md

* conflict

Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* chore(upgrade): changelog and const (#1264)

* chore (deps): bump Ethermint to v0.21.0-rc2 (backport #1269) (#1270)

* chore (deps): bump Ethermint to v0.21.0-rc2 (#1269)

* bump Ethermint to v0.21.0-rc2

* update ethermintserver syntax in root.go

* lint

* update based on review comments

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: tom <tomasguerraalda@hotmail.com>

* update changelog entry

* update PR number

* fix md link

Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* chore: v11-rc2 changelog (#1272)

* fix(app): store upgrades for rc3 (#1276)

* fix(app): store upgrades for rc3

* c++

* fix: test changes deleting module and renaming

* fix: recovery added and deleted

* fix: rename module

* update store loader

* fix: finished store_loader

* Update app/app.go

Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com>

* fix: app.go customStoreLoader

* fix: execute replaced first

* Update app/store_loader.go

Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com>

* fix: original plan of deleting and readding module

* rm loader, update keys

* lint

* c++

* Apply suggestions from code review

Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>

Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com>
Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>

* chore(deps): bump SDK to v0.46.8-ledger (backport #1279) (#1280)

* chore(deps): bump SDK to v0.46.8-ledger (#1279)

* chore(deps): bump SDK to v0.46.8-ledger

* c++

(cherry picked from commit ef71537)

# Conflicts:
#	CHANGELOG.md
#	go.mod
#	go.sum

* Apply suggestions from code review

* conflicts

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* fix(upgrade): remove deletion of recovery module from mainnet upgrade (#1282)

* fix: removed deleted recovery module for mainnet

* run formatting and linting

* upgrade: update olympus-mons distribution (backport #1286) (#1287)

upgrade: update olympus-mons distribution (#1286)

* fix; updated olympus mons distribution

* fix: formatter and linter

(cherry picked from commit ca36b98)

Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com>

* chore (deps): bump ethermint to v0.21.0 (backport #1288) (#1291)

* chore (deps): bump ethermint to v0.21.0 (#1288)

* bump ethermint to v0.21.0

* add changelog entry

(cherry picked from commit efe9cc7)

# Conflicts:
#	CHANGELOG.md

* fix merge conflicts in changelog

* update release on changelog

Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Co-authored-by: MalteHerrmann <malte@evmos.org>

* imp(deps): use informal tendermint (backport #1248) (#1344)

* fix: use informal tendermint (#1248)

(cherry picked from commit 4251d93)

# Conflicts:
#	CHANGELOG.md

* changelog

---------

Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* chore (deps): bump Tendermint to `v0.34.25` (backport #1342) (#1345)

* fix(deps): bump Tendermint to `v0.34.25` (#1342)

* bump Tendermint to v0.34.25

* update changelog

* Apply suggestions from code review

* fix

---------

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
(cherry picked from commit e1da176)

# Conflicts:
#	go.mod
#	go.sum

* conflict

---------

Co-authored-by: Freddy Caceres <facs95@gmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

* imp (proto): add GH action to push Protobuf files to the Buf Schema Registry (backport #1312) (#1346)

imp (proto): add GH action to push Protobuf files to the Buf Schema Registry (#1312)

* add GH action to push protos to BSR

* push only when release tags are created

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>

---------

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
(cherry picked from commit 9cf3d75)

Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>

* fix changelog

* fix

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com>
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Co-authored-by: MalteHerrmann <malte@evmos.org>
Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com>
Co-authored-by: Freddy Caceres <facs95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants