chore(imp) improve cli error messages #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-1470 Improve `gas=auto` error messages
There are external reports being brought to the Evmos team that the automated gas calculation is not always reliable in calculating the needed gas. ---- Example taken from external devs (provided by nic):
Problem: The error msg is actually saying that no fee is provided. However, it is not clear Solution: Refactor error messages to be more informative |
GAtom22
requested review from
Vvaradinov,
0a1c,
facs95,
fedekunze and
MalteHerrmann
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1371 +/- ##
==========================================
- Coverage 72.12% 71.59% -0.53%
==========================================
Files 256 256
Lines 17544 17549 +5
==========================================
- Hits 12653 12565 -88
- Misses 4327 4427 +100
+ Partials 564 557 -7
|
fedekunze
reviewed
Feb 9, 2023
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
fedekunze
approved these changes
Feb 9, 2023
facs95
approved these changes
Feb 9, 2023
|
@Mergifyio backport release/v11.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 9, 2023
* chore(imp) improve cli error messages * Update app/ante/evm/fee_checker.go Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> * chore(imp) add changelog entry --------- Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit 991718f) # Conflicts: # CHANGELOG.md # app/ante/cosmos/min_price.go # app/ante/cosmos/min_price_test.go # app/ante/evm/fee_checker.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve error messages related to gas and fees to be more informative
Closes https://linear.app/evmos/issue/ENG-1470/improve-gas=auto-error-messages