fix(staking): return single struct responses for queries #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-2005 Single struct return from precompile queries - Staking precompile
CurrentWe were wrapping single struct responses in an array because there was an issue with returning the single struct directly. The solution was to wrap the struct in another struct so it can be packed correctly by the ABI in go-ethereum. ExpectedModify the queries and transactions that are wrapping the response in an array to return single struct responses to be more user friendly for SC developers and map correctly to the Cosmos SDK return types. |
Vvaradinov
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1734 +/- ##
==========================================
+ Coverage 70.33% 70.34% +0.01%
==========================================
Files 297 297
Lines 22275 22283 +8
==========================================
+ Hits 15667 15675 +8
Misses 5841 5841
Partials 767 767
|
Vvaradinov
requested review from
MalteHerrmann and
GAtom22
and removed request for
a team
fedekunze
approved these changes
Aug 30, 2023
…om/evmos/evmos into Vvaradinov/staking-single-response # Conflicts: # CHANGELOG.md
|
https://github.com/Mergifyio backport release/v14.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
* fix: modify Staking interface and regenerate abi.json * fix: adjust return responses * fix: convert return types for queries into single structs * add CHANGELOG * fix: CHANGELOG (cherry picked from commit e47d230) # Conflicts: # CHANGELOG.md
|
https://github.com/Mergifyio backport release/v15.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
* fix: modify Staking interface and regenerate abi.json * fix: adjust return responses * fix: convert return types for queries into single structs * add CHANGELOG * fix: CHANGELOG (cherry picked from commit e47d230) # Conflicts: # CHANGELOG.md # precompiles/staking/testdata/StakingCaller.json
Vvaradinov
added a commit
that referenced
this pull request
Oct 17, 2023
) (#1895) * fix(staking): return single struct responses for queries (#1734) * fix: modify Staking interface and regenerate abi.json * fix: adjust return responses * fix: convert return types for queries into single structs * add CHANGELOG * fix: CHANGELOG (cherry picked from commit e47d230) # Conflicts: # CHANGELOG.md # precompiles/staking/testdata/StakingCaller.json * fix conflicts * fix conflicts * fix: regenerate ABI --------- Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com> Co-authored-by: tom <tomasguerraalda@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors some of the queries that previously were wrapped in a slice to avoid errors. Now they return a single struct response as expected from their Cosmos SDK return types.
Closes ENG-2005