imp: remove crisis module in v15 upgrade
#1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facs95
requested review from
Vvaradinov and
MalteHerrmann
and removed request for
a team
facs95
changed the title
crisis module in v15 upgrade
facs95
changed the title
crisis module in v15 upgradecrisis module in v15 upgrade
Codecov Report
@@ Coverage Diff @@
## main #1847 +/- ##
==========================================
- Coverage 70.45% 70.42% -0.03%
==========================================
Files 313 313
Lines 23324 23310 -14
==========================================
- Hits 16432 16416 -16
- Misses 6070 6072 +2
Partials 822 822
|
|
What are the reasons for removing this Crisis module? |
|
https://github.com/Mergifyio backport release/v15.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
(cherry picked from commit a456910) # Conflicts: # CHANGELOG.md # app/app.go # app/upgrades/v15/constants.go # app/upgrades/v15/upgrades.go
GAtom22
added a commit
that referenced
this pull request
Oct 16, 2023
* imp: remove `crisis` module in v15 upgrade (#1847) (cherry picked from commit a456910) # Conflicts: # CHANGELOG.md # app/app.go # app/upgrades/v15/constants.go # app/upgrades/v15/upgrades.go * fix conflicts --------- Co-authored-by: Freddy Caceres <facs95@gmail.com> Co-authored-by: tom <tomasguerraalda@hotmail.com> Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing crisis module since it is not being used an instantiating v15 upgrade handler.
Closes #XXX