Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testnet): remove the crisis module causing an error when using the evmosd testnet init-files command #1857

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

luchenqun
Copy link
Contributor

@luchenqun luchenqun commented Oct 13, 2023

Description

I noticed that you have removed the Crisis module in the NewEvmos function in #1847, but you forgot to remove the corresponding logic in the initGenFiles function, which caused a panic error when using the command evmosd testnet init-files --v 2 --output-dir ./nodes --chain-id evmos_9000-1 --keyring-backend test. I have made a simple fix for this.


Closes #XXX

@luchenqun luchenqun requested a review from a team as a code owner October 13, 2023 08:32
@luchenqun luchenqun requested review from Vvaradinov and facs95 and removed request for a team October 13, 2023 08:32
@CLAassistant
Copy link

CLAassistant commented Oct 13, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@fedekunze
Copy link
Contributor

@luchenqun can you lint the code?

@luchenqun
Copy link
Contributor Author

@luchenqun can you lint the code?
Yes, I executed the make lint command, but they were all errors related to contract code and had nothing to do with my changes.

make lint
golangci-lint run --out-format=tab
solhint contracts/**/*.sol

contracts/node_modules/@openzeppelin/contracts/access/AccessControlEnumerable.sol
  34:2  error  Line length must be no more than 120 but current length is 123  max-line-length

contracts/node_modules/@openzeppelin/contracts/access/IAccessControlEnumerable.sol
  21:2  error  Line length must be no more than 120 but current length is 123  max-line-length

contracts/node_modules/@openzeppelin/contracts/crosschain/optimism/CrossChainEnabledOptimism.sol
  15:2  error  Line length must be no more than 120 but current length is 148  max-line-length

contracts/node_modules/@openzeppelin/contracts/crosschain/polygon/CrossChainEnabledPolygonChild.sol
  22:2  error  Line length must be no more than 120 but current length is 133  max-line-length

contracts/node_modules/@openzeppelin/contracts/governance/extensions/GovernorTimelockCompound.sol
  55:2  error  Line length must be no more than 120 but current length is 121  max-line-length

contracts/node_modules/@openzeppelin/contracts/governance/extensions/GovernorVotes.sol
  10:2  error  Line length must be no more than 120 but current length is 126  max-line-length

contracts/node_modules/@openzeppelin/contracts/governance/Governor.sol
   83:2  error  Line length must be no more than 120 but current length is 121  max-line-length
  194:2  error  Line length must be no more than 120 but current length is 127  max-line-length

contracts/node_modules/@openzeppelin/contracts/governance/IGovernor.sol
  87:2  error  Line length must be no more than 120 but current length is 121  max-line-length

contracts/node_modules/@openzeppelin/contracts/proxy/Proxy.sol
  48:2  error  Line length must be no more than 120 but current length is 121  max-line-length

contracts/node_modules/@openzeppelin/contracts/proxy/transparent/TransparentUpgradeableProxy.sol
  58:2  error  Line length must be no more than 120 but current length is 122  max-line-length
  71:2  error  Line length must be no more than 120 but current length is 122  max-line-length

contracts/node_modules/@openzeppelin/contracts/security/PullPayment.sol
  10:2  error  Line length must be no more than 120 but current length is 131  max-line-length

contracts/node_modules/@openzeppelin/contracts/token/ERC1155/IERC1155Receiver.sol
  49:2  error  Line length must be no more than 120 but current length is 126  max-line-length

contracts/node_modules/@openzeppelin/contracts/token/ERC20/extensions/ERC20Snapshot.sol
  151:2  error  Line length must be no more than 120 but current length is 123  max-line-length
  155:2  error  Line length must be no more than 120 but current length is 123  max-line-length
  159:2  error  Line length must be no more than 120 but current length is 122  max-line-length
  160:2  error  Line length must be no more than 120 but current length is 122  max-line-length

contracts/node_modules/@openzeppelin/contracts/token/ERC20/extensions/ERC20Votes.sol
  101:2  error  Line length must be no more than 120 but current length is 122  max-line-length

contracts/node_modules/@openzeppelin/contracts/token/ERC721/ERC721.sol
  199:2  error  Line length must be no more than 120 but current length is 136  max-line-length
  243:2  error  Line length must be no more than 120 but current length is 136  max-line-length

contracts/node_modules/@openzeppelin/contracts/token/ERC721/IERC721.sol
  50:2  error  Line length must be no more than 120 but current length is 136  max-line-length
  70:2  error  Line length must be no more than 120 but current length is 126  max-line-length
  71:2  error  Line length must be no more than 120 but current length is 136  max-line-length

contracts/node_modules/@openzeppelin/contracts/token/ERC721/IERC721Receiver.sol
  17:2  error  Line length must be no more than 120 but current length is 122  max-line-length

contracts/node_modules/@openzeppelin/contracts/token/ERC721/utils/ERC721Holder.sol
  12:2  error  Line length must be no more than 120 but current length is 133  max-line-length

contracts/node_modules/@openzeppelin/contracts/utils/Address.sol
  58:2  error  Line length must be no more than 120 but current length is 160  max-line-length
  76:2  error  Line length must be no more than 120 but current length is 156  max-line-length

contracts/node_modules/@openzeppelin/contracts/utils/math/Math.sol
   51:2  error  Line length must be no more than 120 but current length is 130  max-line-length
   95:2  error  Line length must be no more than 120 but current length is 124  max-line-length
  119:2  error  Line length must be no more than 120 but current length is 123  max-line-length

contracts/node_modules/@openzeppelin/contracts/utils/StorageSlot.sol
  17:2  error  Line length must be no more than 120 but current length is 123  max-line-length

contracts/node_modules/@openzeppelin/contracts/utils/Strings.sol
  70:2  error  Line length must be no more than 120 but current length is 129  max-line-length

contracts/node_modules/@openzeppelin/contracts/utils/structs/BitMaps.sol
  7:2  error  Line length must be no more than 120 but current length is 144  max-line-length

contracts/node_modules/@openzeppelin/contracts/utils/structs/EnumerableMap.sol
  39:2  error  Line length must be no more than 120 but current length is 123  max-line-length
  42:2  error  Line length must be no more than 120 but current length is 145  max-line-length

contracts/node_modules/@openzeppelin/contracts/utils/structs/EnumerableSet.sol
  32:2  error  Line length must be no more than 120 but current length is 123  max-line-length
  35:2  error  Line length must be no more than 120 but current length is 145  max-line-length

contracts/node_modules/@openzeppelin/contracts/vendor/arbitrum/IArbSys.sol
   6:2  error  Line length must be no more than 120 but current length is 176  max-line-length
  40:2  error  Line length must be no more than 120 but current length is 135  max-line-length
  42:2  error  Line length must be no more than 120 but current length is 131  max-line-length

contracts/node_modules/@openzeppelin/contracts/vendor/compound/ICompoundTimelock.sol
  7:2  error  Line length must be no more than 120 but current length is 122  max-line-length

✖ 42 problems (42 errors, 0 warnings)

client/testnet.go Outdated Show resolved Hide resolved
@fedekunze fedekunze merged commit 18f47b3 into evmos:main Oct 13, 2023
29 of 31 checks passed
@GAtom22
Copy link
Contributor

GAtom22 commented Oct 16, 2023

https://github.com/Mergifyio backport release/v15.0.x

@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2023

backport release/v15.0.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 16, 2023
…e `evmosd testnet init-files` command (#1857)

* fix(testnet): remove the crisis module causing an error when using the evmosd testnet init-files command

* chore: run make format

(cherry picked from commit 18f47b3)

# Conflicts:
#	CHANGELOG.md
GAtom22 added a commit that referenced this pull request Oct 16, 2023
…e `evmosd testnet init-files` command (backport #1857) (#1892)

* fix(testnet): remove the crisis module causing an error when using the `evmosd testnet init-files` command (#1857)

* fix(testnet): remove the crisis module causing an error when using the evmosd testnet init-files command

* chore: run make format

(cherry picked from commit 18f47b3)

# Conflicts:
#	CHANGELOG.md

* fix conflicts

---------

Co-authored-by: Chenqun Lu <luchenqun@qq.com>
Co-authored-by: tom <tomasguerraalda@hotmail.com>
Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants