fix(ics20): Extract grant checking and updating functions for reuse #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vvaradinov
requested review from
facs95 and
GAtom22
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #1850 +/- ##
==========================================
+ Coverage 70.38% 70.58% +0.20%
==========================================
Files 314 314
Lines 23422 23369 -53
==========================================
+ Hits 16486 16496 +10
+ Misses 6121 6058 -63
Partials 815 815
|
# Conflicts: # CHANGELOG.md # precompiles/authorization/IICS20Authorization.sol # precompiles/authorization/events.go # precompiles/common/Types.sol # precompiles/common/types.go # precompiles/ics20/abi.json # precompiles/ics20/approve_common.go # precompiles/ics20/approve_test.go # precompiles/ics20/events.go # precompiles/ics20/events_test.go # precompiles/ics20/integration_test.go # precompiles/ics20/query.go # precompiles/ics20/query_test.go # precompiles/ics20/tx.go # precompiles/ics20/types.go # precompiles/ics20/utils_test.go
…s' into Vvaradinov/common-grant-functions
GAtom22
approved these changes
Oct 12, 2023
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
|
https://github.com/Mergifyio backport release/v15.0.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
…1850) * fix: add some of the refactors * add CHANGELOG * fix: common approval logic and test refactor to use the new event emitting * fix: extract check and update grant functions for case when smart contracts are calling * CHANGELOG * CHANGELOG * fix: added back changes needed * fix: remove unused event * CHANGELOG * format and lint * Apply suggestions from code review Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> --------- Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> (cherry picked from commit 6d2d0f1) # Conflicts: # CHANGELOG.md # precompiles/ics20/events.go # precompiles/ics20/tx.go # precompiles/ics20/types.go
Vvaradinov
added a commit
that referenced
this pull request
Oct 16, 2023
…backport #1850) (#1872) * fix(ics20): Extract grant checking and updating functions for reuse (#1850) * fix: add some of the refactors * add CHANGELOG * fix: common approval logic and test refactor to use the new event emitting * fix: extract check and update grant functions for case when smart contracts are calling * CHANGELOG * CHANGELOG * fix: added back changes needed * fix: remove unused event * CHANGELOG * format and lint * Apply suggestions from code review Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> --------- Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> (cherry picked from commit 6d2d0f1) # Conflicts: # CHANGELOG.md # precompiles/ics20/events.go # precompiles/ics20/tx.go # precompiles/ics20/types.go * fix: remove merge marks * fix: correct type for Transfer Authz --------- Co-authored-by: Vladislav Varadinov <vladislav.varadinov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the 3rd PR extracting the Grant checking and updating logic so it can be easily re-used in future Outposts or extension utilizing ICS20 Transfers.
Closes #XXX