tests(erc20): Add tests for ERC20 allowance transactions #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalteHerrmann
requested review from
Vvaradinov and
GAtom22
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2083 +/- ##
=======================================
Coverage 70.14% 70.15%
=======================================
Files 339 339
Lines 25499 25499
=======================================
+ Hits 17887 17889 +2
+ Misses 6675 6673 -2
Partials 937 937 |
fedekunze
previously requested changes
Nov 28, 2023
There was a problem hiding this comment.
Thanks @MalteHerrmann let's also check the result (true or false) in the approve calls
# Conflicts: # CHANGELOG.md # precompiles/erc20/integration_test.go
MalteHerrmann
dismissed
fedekunze’s stale review
Addressed the open points :+1
fedekunze
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the integration tests for the ERC20 EVM extension transactions, that handle allowances as part of merging #2044 in smaller chunks.