tests(erc20): Add ERC20 transfer integration tests #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalteHerrmann
requested review from
Vvaradinov and
facs95
and removed request for
a team
|
The failing tests are fixed by #2088 through emitting the additional approval event in case of a |
fedekunze
reviewed
Nov 27, 2023
0xstepit
reviewed
Nov 28, 2023
0xstepit
reviewed
Nov 28, 2023
0xstepit
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Great Job @MalteHerrmann, very clean and well organized tests. Just left some nit.
fedekunze
requested changes
Nov 28, 2023
MalteHerrmann
commented
Nov 28, 2023
There was a problem hiding this comment.
@fedekunze good points, I've addressed your suggestion to check the bool values and will apply those changes to the other PRs too.
It would be good to merge this one first before adjust the other PRs, so the changes to the ERC20AllowanceCaller.sol don't have to be repeated
fedekunze
approved these changes
Nov 28, 2023
|
tests will be fixed in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds integration tests for ERC20 transfers in the process of merging #2044 in smaller chunks.