Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strengthening hash #64

Closed
PEMapModder opened this issue Jan 17, 2016 · 9 comments
Closed

Strengthening hash #64

PEMapModder opened this issue Jan 17, 2016 · 9 comments
Milestone

Comments

@PEMapModder
Copy link
Contributor

Hash security can be strengthened with salt. If you add the username as salt (remember to make it case-insensitive) to the password, in case the database is leaked, it is less easy to find out that two people have the same password.

@Flavius12
Copy link
Member

Thanks for the suggestion 👍

@PEMapModder
Copy link
Contributor Author

Note the difficulty of backwards compatibility. You might need to hash with both algos, delete old hash and store new hash when players login so as to support hashes generated in previous versions.

@Flavius12
Copy link
Member

Ok. I'll keep this in mind

@PEMapModder
Copy link
Contributor Author

I just found this from php.net, explaining the danger of directly using a simple hash algorithm.

@PEMapModder
Copy link
Contributor Author

This might give some inspiration PEMapModder/HereAuth@7e5836c

@Flavius12
Copy link
Member

Thanks 😄

@legoboy0215
Copy link
Contributor

Use password_hash. BCrypt 4 life.

@Flavius12
Copy link
Member

A new multi hash feature is coming to the new version of ServerAuth.

@Flavius12 Flavius12 added this to the 3.0 milestone May 10, 2018
@Flavius12
Copy link
Member

Coming in v3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants