-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #297
Update dependencies #297
Conversation
@@ -34,10 +35,7 @@ buildscript { | |||
} | |||
|
|||
dependencies { | |||
classpath 'com.android.tools.build:gradle:3.5.3' | |||
classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.8.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plugin didn't seem to be used, so I removed it
@@ -34,10 +35,7 @@ buildscript { | |||
} | |||
|
|||
dependencies { | |||
classpath 'com.android.tools.build:gradle:3.5.3' | |||
classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.8.4' | |||
classpath 'com.github.dcendents:android-maven-gradle-plugin:2.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plugin didn't seem to be used, and is no longer maintained so I removed it
classpath 'com.android.tools.build:gradle:3.5.3' | ||
classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.8.4' | ||
classpath 'com.github.dcendents:android-maven-gradle-plugin:2.1' | ||
classpath 'com.novoda:bintray-release:0.9.1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plugin is not yet compatible with Gradle 6+
desc = 'TableView is a powerful Android library for displaying complex data structures and rendering tabular data composed of rows, columns and cells.' | ||
website = 'https://github.com/evrencoskun/TableView' //website | ||
// Configure the publishing | ||
apply plugin: 'maven-publish' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Android Gradle Plugin 3.6, Gradle's Maven Publish Plugin is supported for Android projects.
I configured it so you don't depend on third party plugins. If you prefer to use an existing plugin, let me know and I'll revert my changes.
I can also revert to the latest Gradle 5 release, if you want to stay with com.novoda.bintray-release
plugin
I tried this change on my side by running ./gradlew :tableview:publishReleasePublicationToMavenLocal
, and I ended up with the AAR file, the corresponding POM file with the dependencies, the sources JAR and the Javadoc JAR. I couldn't test a publication on the actual Bintray repository though (you should be able to do it by running ./gradlew :tableview:publishReleasePublicationToMavenRepository
).
I've updated the dependencies of the project:
I've also removed some Gradle plugins (see related comments below) and fixed some warnings.