Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default get*ItemViewType implementations to AbstractTableAdapter #369

Conversation

MGaetan89
Copy link
Contributor

This PR adds default implementation of getColumnHeaderItemViewType, getRowHeaderItemViewType and getCellItemViewType to AbstractTableAdapter. This replicates the behaviour of RecyclerView.Adpter, where getItemViewType doesn't need to be overriden if we only have one type.

@evrencoskun evrencoskun merged commit cd1c561 into evrencoskun:master Mar 15, 2021
@MGaetan89 MGaetan89 deleted the abtract_table_adapter_default_methods branch March 15, 2021 07:45
@MGaetan89
Copy link
Contributor Author

@evrencoskun any plan to do a new release?
I think some of these changes could be useful: v0.8.9.2...master

@evrencoskun
Copy link
Owner

Hi, @MGaetan89
Yes, you are right!
But I'm facing an issue when I try to generate a new release. So, firstly, I need to have a look at it.

Cheers!

@MGaetan89
Copy link
Contributor Author

When I updated the plugins and dependencies in #297, I changed the way to generate a new release.
I've documented it in this comment: #297 (comment)
Have you tried that? Let me know if I can help you in any way :)

I made that changes because com.novoda:bintray-release was not compatible with Gradle 6+ (and hasn't been updated since).

@evrencoskun
Copy link
Owner

@MGaetan89
As far as I remember, I had read your comments before I tried it. But I'll try one more time.

Thank you for your collaboration :)

@Zardozz
Copy link

Zardozz commented Mar 18, 2021

May be it is worth publishing elsewhere if you are having problems as it seem JCenter/Bintray is closing down

https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/

@evrencoskun
Copy link
Owner

@Zardozz Right - In the long run, it will be necessary to move elsewhere.

Cheers!

@Zardozz
Copy link

Zardozz commented Mar 18, 2021

I've just published another project to Maven Central (one of the alternatives)

The guide https://getstream.io/blog/publishing-libraries-to-mavencentral-2021/ was very good

@evrencoskun
Copy link
Owner

@Zardozz noted - Thanks!

@santiihoyos
Copy link

Same problem

@MGaetan89
Copy link
Contributor Author

What problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants