Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcriber would break if tags differ between files #1

Closed
ewancook opened this issue Apr 20, 2020 · 3 comments · Fixed by #2
Closed

Transcriber would break if tags differ between files #1

ewancook opened this issue Apr 20, 2020 · 3 comments · Fixed by #2

Comments

@ewancook
Copy link
Owner

For example:

  • Tag added midway through a series of files
  • Float files contain data different to Tagname

etc.

This would break the fast, maths based transcription - would need to use a dict of tags again...

@ewancook ewancook changed the title Transcriber would break if a tags differ between files Transcriber would break if tags differ between files Apr 20, 2020
@ewancook
Copy link
Owner Author

Update:

Since (Float).DAT files contain TagIndex and not Tagname, individual (Tagname).DAT files for every float file would be required at some stage in parsing & checking, in order to prevent the above.

If all tag files were provided, float files could be grouped by the tags they contain, allowing tags to be selected for each group. The current fast parsing implementation could then be used.

This would require a GUI redesign and some refactoring.

@ewancook
Copy link
Owner Author

Note: since transcriber does not read tags during transcription, errors may occur if an incorrect tag file is used. These could be any of:

  • If the tagfile has more tags than the float file. an error will occur on reaching the end of the float file
  • If the tagfile has fewer tags than the float file, the transcribed csv file will be incomplete
  • If the tagfile has a different number of tags than the float file, values will not be consistent within columns

@ewancook
Copy link
Owner Author

ewancook commented May 9, 2020

Comparing SubclassedDBF.header.numrecords to tag_selecter.presenter.active_tags would allow any (Float.DAT) files with an incorrect number of tags to be identified!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant