Value exceeds 64 bits

[hugo-dc]

I wrote a new test case in order to validate that we get an OOG exception when there is a call sending a value and the value is higher than the current sender Balance. Instead the result is the following:

100%
Executing...
importGlobals
DEBUG printMemHex(0x14:0x20): 20 a1 7 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
InternalError: Value exceeds 64 bits.
Executing...
importGlobals
DEBUG printMemHex(0x14:0x20): 20 a1 7 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
InternalError: Value exceeds 64 bits.

hera/src/eei.cpp

Line 875 in 1a219f0

if (safeLoadUint64(balance) < safeLoadUint64(value))

Here it is comparint the balance and value, both are u128 and it is being validated by a function that validates 64 bit numbers.

[axic]

This is also an endianess issue.

[axic]

Also there should be test cases for using > 64 bit values.

[jwasinger]

Related: ewasm/evm2wasm#219

[axic]

The other problem here is that ensureSenderBalance is just broken, because it uses safeLoadUin128, which truncates the value into uin64_t.

ensureSenderBalance should be rewritten to properly handle the values.

[axic]

Test case creation is tracked here: ewasm/tests#42