Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Value should be 256 bits #197

Closed
jwasinger opened this issue May 2, 2018 · 1 comment
Closed

Transaction Value should be 256 bits #197

jwasinger opened this issue May 2, 2018 · 1 comment

Comments

@jwasinger
Copy link
Contributor

jwasinger commented May 2, 2018

According to YP figure 16, tx value is 256 bits in size.

Hera is expecting a transaction value to be 128 bits: https://github.com/ewasm/hera/blob/master/src/eei.cpp#L607

I'm working on a fix but I'm stuck on trying to compare two evmc_uint256be to change this line: https://github.com/ewasm/hera/blob/master/src/eei.cpp#L880 . @axic @jakelang know of any code that does this?

@jwasinger
Copy link
Contributor Author

jwasinger commented May 2, 2018

YP omits a limit for the transaction value. The limit is 128 bits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant