New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Python 3.6 and 3.7 support, add 3.12 #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tree with time and mode unpreserved
vladsavelyev
changed the base branch from
replace-distuils
to
bundle-lzstring
October 16, 2023 07:35
vladsavelyev
force-pushed
the
drop-3.7
branch
from
October 16, 2023 07:37
eb0a09c
to
c0ca26c
Compare
ewels
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
dlaehnemann
added a commit
to snakemake-workflows/dna-seq-varlociraptor
that referenced
this pull request
Nov 8, 2023
The newest `multiqc` version fixes the incompatibilities with python 3.12: MultiQC/MultiQC#2121
johanneskoester
pushed a commit
to snakemake-workflows/dna-seq-varlociraptor
that referenced
this pull request
Nov 10, 2023
…#272) * fix: update fastqc wrapper to `v1.10.0` to include memory parsing fix The memory parsing fix for the wrapper was introduced in `snakemake-wrapper-utils` here: snakemake/snakemake-wrapper-utils#34 * fix: update multiqc wrapper to `v2.10.0` to pull in multiqc `v1.17.0` The newest `multiqc` version fixes the incompatibilities with python 3.12: MultiQC/MultiQC#2121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2039
See also PRs for 3.12 support:
distutils
#2113Stacked on #2113 and #2119