Battery's charging_state and battery_level characteristics are defined as optional even though they're required.

[gbaranski]

you can find that here

https://github.com/ewilken/hap-rs/blob/main/src/service/generated/battery.rs#L34-L37

And according to the specification, those two are required.

[ewilken]

Thanks for checking! I just re-ran the codegen under macOS 12.0.1 and it generated the two characteristics as optional. So Apple's own implementation in macOS ist diverging from the spec here. Are you reading the latest version of the spec? And is the iOS controller complaining (read: not pairing) about our implementation? If it works, I'd say let's just stick with replicating Apple's implementation and call it a day.

[gbaranski]

Are you reading the latest version of the spec?

Yes, I think so.

And is the iOS controller complaining (read: not pairing) about our implementation?

It does connect, but it seemed weird.

Thanks for clarifying, should I keep the issue open?

[ewilken]

I'd say let's close it. But please feel free to reopen should you run into any related issues!