Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpotion retired #958

Closed
wkirschbaum opened this issue Jun 23, 2023 · 3 comments
Closed

httpotion retired #958

wkirschbaum opened this issue Jun 23, 2023 · 3 comments

Comments

@wkirschbaum
Copy link
Contributor

When running mix deps.get, the following warning pops up:

 httpotion 3.2.0 RETIRED!
    (deprecated) Not really maintained, please check out Tesla

but think instead of Tesla perhaps we should use Finch.

@wkirschbaum
Copy link
Contributor Author

related: dashbitco/broadway_sqs#73

@bernardd
Copy link
Contributor

I don't really have a strong opinion on the preferred alternative, so I'd be happy with a PR for either (or httpoison, which I mention merely because it has a pleasingly similar name, and not because I have any knowledge or opinion of the relative technical merits). Note, though, that the selection of httpotion is only for testing, and the idea is that, as with the JSON library, you should be able to plug in any backend you like. So as long as that remains the case, I'm pretty much happy with whatever.

@wkirschbaum
Copy link
Contributor Author

@bernardd just as an idea and should not be a breaking change: #960

This will also allow Finch to be used as Req is built on top of Finch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants