Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #10

Merged
merged 2 commits into from Nov 30, 2017
Merged

Update README.md #10

merged 2 commits into from Nov 30, 2017

Conversation

ghost
Copy link

@ghost ghost commented Nov 29, 2017

type.introspection? ? ->(obj, args, ctx) { false } : RULES.dig(type, field)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5ac1521 on johnunclesam:patch-1 into cd1ca47 on exAspArk:master.

@exAspArk
Copy link
Owner

exAspArk commented Nov 29, 2017

The intention in the #6 was the opposite. Not to prevent accessing introspection types but to "allow introspection queries to skip authorization".

Could you please change the example to something like:

if type.introspection?
  ->(obj, args, ctx) { true } # of "false" to restrict an access
else
  RULES.dig(type, field)
end

?

@ghost
Copy link
Author

ghost commented Nov 29, 2017

Sorry. You're right.

Allow introspection queries to skip authorization. Or false to prevent.

Also "_ (underscore)" to useless arguments.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a4ba20d on johnunclesam:patch-1 into cd1ca47 on exAspArk:master.

@exAspArk exAspArk merged commit 1d79cd5 into exAspArk:master Nov 30, 2017
@exAspArk
Copy link
Owner

@johnunclesam thank you for contributing! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants