Update README.md with details for whitelisting introspection queries. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanishev
changed the title
exAspArk
reviewed
Oct 30, 2017
README.md
Outdated
| @@ -128,6 +128,13 @@ Schema = GraphQL::Schema.define do | |||
| end | |||
| </pre> | |||
|
|
|||
| When using a policy object, you may want to allow [introspection queries](http://graphql.org/learn/introspection/) to skip authorization. A simple way to avoid having to whitelist every introspection type in the RULES hash of your policy object is to check the <b>type</b> in the guard method: | |||
There was a problem hiding this comment.
could you please wrap `RULES`, so it's clear that we're referring a variable from the source code? :)
|
@stanishev thank you so much for contributing! 🙌
I squashed your commits and merged the PR manually ac7285e. Closed the #4. |
|
Can you release this in 1.0.1 please? |
|
I tried with the master branch in my Gemfile but it still doesn't work: #7 |
This was referenced Nov 27, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to keep the changes to a minimum, while also keeping the new section clear. I didn't create a separate section as you suggested, because I thought that the introspection bit makes sense only in the context of using a GraphQLPolicy object (so policy 4), so it seemed natural to append it to the existing section.