Skip to content
This repository has been archived by the owner on Oct 27, 2024. It is now read-only.

Import broken on main branch #48

Open
aazuspan opened this issue Sep 8, 2022 · 0 comments
Open

Import broken on main branch #48

aazuspan opened this issue Sep 8, 2022 · 0 comments

Comments

@aazuspan
Copy link

aazuspan commented Sep 8, 2022

Hi @exTerEX, this is a cool project, but it looks like there's some leftover code in the main branch that breaks imports if you install from source, and might be exposing an API key.

Running import noaa after installing with python -m pip install git+https://github.com/exTerEX/noaa.git#egg=noaa throws:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\Aaron\miniconda3\envs\geostats\lib\site-packages\noaa\__init__.py", line 1, in <module>
    import noaa
  File "C:\Users\Aaron\miniconda3\envs\geostats\lib\site-packages\noaa\climate.py", line 624, in <module>
    noaaobj = NOAA("xxxxxxxxxxxx")
NameError: name 'NOAA' is not defined

I redacted the actual key in the exception above.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant